2013-10-26 02:34:31

by Daniel Walker

Subject: [PATCH 3/3] cgroups: remove calls to simple_kstrtoll

Signed-off-by: Daniel Walker <[email protected]>
---
kernel/cgroup.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 41f71c3..bf8b891 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2276,7 +2276,7 @@ static ssize_t cgroup_write_X64(struct cgroup_subsys_state *css,
{
char buffer[CGROUP_LOCAL_BUFFER_SIZE];
int retval = 0;
- char *end;
+ int ret;

if (!nbytes)
return -EINVAL;
@@ -2287,13 +2287,15 @@ static ssize_t cgroup_write_X64(struct cgroup_subsys_state *css,

buffer[nbytes] = 0; /* nul-terminate */
if (cft->write_u64) {
- u64 val = simple_strtoull(strstrip(buffer), &end, 0);
- if (*end)
+ u64 val;
+ ret = kstrtoull(strstrip(buffer), 0, &val);
+ if (ret != 0)
return -EINVAL;
retval = cft->write_u64(css, cft, val);
} else {
- s64 val = simple_strtoll(strstrip(buffer), &end, 0);
- if (*end)
+ s64 val;
+ ret = kstrtoll(strstrip(buffer), 0, &val);
+ if (ret != 0)
return -EINVAL;
retval = cft->write_s64(css, cft, val);
}
--
1.8.3.2

2013-10-27 11:39:30

by Tejun Heo

Subject: Re: [PATCH 3/3] cgroups: remove calls to simple_kstrtoll

On Fri, Oct 25, 2013 at 07:33:13PM -0700, Daniel Walker wrote:
> Signed-off-by: Daniel Walker <[email protected]>

Can you please briefly explain why this conversion is happening in the
patch description?

Thanks.

--
tejun

2013-10-27 15:12:08

by Daniel Walker

Subject: Re: [PATCH 3/3] cgroups: remove calls to simple_kstrtoll

Sure , I can add it .. It's because simple_strtoll is obsolete ..

On Sun, Oct 27, 2013 at 07:39:25AM -0400, Tejun Heo wrote:
> On Fri, Oct 25, 2013 at 07:33:13PM -0700, Daniel Walker wrote:
> > Signed-off-by: Daniel Walker <[email protected]>
>
> Can you please briefly explain why this conversion is happening in the
> patch description?
>
> Thanks.
>
> --
> tejun
>