2013-10-28 14:33:43

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the final tree (device-mapper tree related)

---

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/md/dm-cache-policy-hints.c: In function 'alloc_hash':
drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
^
drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
^
drivers/md/dm-cache-policy-hints.c: In function 'free_hash':
drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(hash->table);
^
drivers/md/dm-cache-policy-hints.c: In function 'alloc_bitset':
drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]
return vzalloc(sizeof(unsigned long) * bit_set_nr_words(nr_cblocks));
^

Caused by commit ce567d11e819 ("dm cache: add hints policy") from the
device-mapper tree.

I have just left this broken for today.
--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (1.23 kB)
(No filename) (836.00 B)
Download all attachments

2013-10-28 14:57:41

by Mike Snitzer

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (device-mapper tree related)

---

On Mon, Oct 28 2013 at 10:33am -0400,
Stephen Rothwell <[email protected]> wrote:

> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/md/dm-cache-policy-hints.c: In function 'alloc_hash':
> drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
> hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
> ^
> drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
> hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
> ^
> drivers/md/dm-cache-policy-hints.c: In function 'free_hash':
> drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(hash->table);
> ^
> drivers/md/dm-cache-policy-hints.c: In function 'alloc_bitset':
> drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]
> return vzalloc(sizeof(unsigned long) * bit_set_nr_words(nr_cblocks));
> ^
>
> Caused by commit ce567d11e819 ("dm cache: add hints policy") from the
> device-mapper tree.
>
> I have just left this broken for today.

I just pushed an update to linux-dm.git's 'for-next' branch which adds
3 missing #includes to drivers/md/dm-cache-policy-hints.c

Thanks,
Mike