2013-10-30 05:34:27

by Wei Yongjun

Subject: [PATCH -next] mtd: remove duplicated include from mtdcore.c

From: Wei Yongjun <[email protected]>

Remove duplicated include.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/mtd/mtdcore.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 7189089..92311a5 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -37,7 +37,6 @@
#include <linux/backing-dev.h>
#include <linux/gfp.h>
#include <linux/slab.h>
-#include <linux/major.h>

#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>

2013-10-30 09:56:42

by Ezequiel Garcia

Subject: Re: [PATCH -next] mtd: remove duplicated include from mtdcore.c

On Wed, Oct 30, 2013 at 01:34:22PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/mtd/mtdcore.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 7189089..92311a5 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -37,7 +37,6 @@
> #include <linux/backing-dev.h>
> #include <linux/gfp.h>
> #include <linux/slab.h>
> -#include <linux/major.h>
>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
>
>

Acked-by: Ezequiel Garcia <[email protected]>

Ooops.. sorry about that. This was introduced by me in this one:

commit 40d1b2e461f28c4add582ef7ca8ed9f16f6b5add
Author: Ezequiel Garcia <[email protected]>
Date: Sun Oct 13 18:05:23 2013 -0300

mtd: Move major number definitions to major.h
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

2013-10-30 21:37:51

by Brian Norris

Subject: Re: [PATCH -next] mtd: remove duplicated include from mtdcore.c

On Wed, Oct 30, 2013 at 06:56:41AM -0300, Ezequiel Garcia wrote:
> On Wed, Oct 30, 2013 at 01:34:22PM +0800, Wei Yongjun wrote:
> > From: Wei Yongjun <[email protected]>
> >
> > Remove duplicated include.
> >
> > Signed-off-by: Wei Yongjun <[email protected]>
> > ---
> > drivers/mtd/mtdcore.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 7189089..92311a5 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -37,7 +37,6 @@
> > #include <linux/backing-dev.h>
> > #include <linux/gfp.h>
> > #include <linux/slab.h>
> > -#include <linux/major.h>
> >
> > #include <linux/mtd/mtd.h>
> > #include <linux/mtd/partitions.h>
> >
> >
>
> Acked-by: Ezequiel Garcia <[email protected]>

Pushed to l2-mtd.git, thanks Wei! It probably could just be squashed
into the original patch, but I'm not sure it's actually worth the
rebase.

Brian