2013-10-30 20:22:25

by Cyrill Gorcunov

[permalink] [raw]
Subject: [patch 0/6] Rework file::show_fdinfo method to use seq-files engine

Hi, in criu we intensively use additional information provided by
/proc/<pid>/fdinfo/<fd> particular to the object opened file
represents. The output is printed out by file_operations::show_fdinfo
method and the implementation of this method is pretty simple. Still
I think better would be to convert this method to seq_operations pointer
where all suppliers (epoll, eventfd and such) provide own seq-file
operations. While this makes code a little more complex this will
decrease the amount of kernel memory needed for output (because
we won't need to provide all information in one pass but by chunks).

Please take a look, thanks!