2014-01-06 07:03:18

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the spi tree

---

Hi Mark,

After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/spi/spi-dw-pci.c: In function 'spi_pci_probe':
drivers/spi/spi-dw-pci.c:50:29: error: 'dev' undeclared (first use in this function)
dwpci = devm_kzalloc(&pdev-dev, sizeof(struct dw_spi_pci), GFP_KERNEL);
^

Caused by commit 04f421e7b0b1 ("spi: dw: use managed resources").

I have used the spi tree from next-20131224 for today (since the above
commit does not revert cleanly).

--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (591.00 B)
(No filename) (836.00 B)
Download all attachments

2014-01-06 07:09:12

by Baruch Siach

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the spi tree

---

Hi Stephen,

On Mon, Jan 06, 2014 at 06:03:05PM +1100, Stephen Rothwell wrote:
> After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/spi/spi-dw-pci.c: In function 'spi_pci_probe':
> drivers/spi/spi-dw-pci.c:50:29: error: 'dev' undeclared (first use in this function)
> dwpci = devm_kzalloc(&pdev-dev, sizeof(struct dw_spi_pci), GFP_KERNEL);
> ^
>
> Caused by commit 04f421e7b0b1 ("spi: dw: use managed resources").
>
> I have used the spi tree from next-20131224 for today (since the above
> commit does not revert cleanly).

Sorry, my bad (I said I have no way to test this PCI code, didn't I?). I'll
send a fix shortly.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -