Em Thu, 26 Dec 2013 19:09:10 +0800
Ding Tianhong <[email protected]> escreveu:
> On 2013/12/25 18:57, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 25-12-2013 7:29, Ding Tianhong wrote:
> >
> >> Use possibly more efficient ether_addr_equal
> >> instead of memcmp.
> >
> >> Cc: Mauro Carvalho Chehab <[email protected]>
> >> Cc: [email protected]
> >> Cc: [email protected]
> >> Signed-off-by: Yang Yingliang <[email protected]>
> >> Signed-off-by: Ding Tianhong <[email protected]>
> >> ---
> >> drivers/media/dvb-core/dvb_net.c | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> >> diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
> >> index f91c80c..3dfc33b 100644
> >> --- a/drivers/media/dvb-core/dvb_net.c
> >> +++ b/drivers/media/dvb-core/dvb_net.c
> >> @@ -179,7 +179,7 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *skb,
> >> eth = eth_hdr(skb);
> >>
> >> if (*eth->h_dest & 1) {
> >> - if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0)
> >> + if(ether_addr_equal(eth->h_dest,dev->broadcast))
> >
> > There should be space after comma.
> >
> >> @@ -674,11 +674,11 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len )
> >> if (priv->rx_mode != RX_MODE_PROMISC) {
> >> if (priv->ule_skb->data[0] & 0x01) {
> >> /* multicast or broadcast */
> >> - if (memcmp(priv->ule_skb->data, bc_addr, ETH_ALEN)) {
> >> + if (!ether_addr_equal(priv->ule_skb->data, bc_addr)) {
> >> /* multicast */
> >> if (priv->rx_mode == RX_MODE_MULTI) {
> >> int i;
> >> - for(i = 0; i < priv->multi_num && memcmp(priv->ule_skb->data, priv->multi_macs[i], ETH_ALEN); i++)
> >> + for(i = 0; i < priv->multi_num && !ether_addr_equal(priv->ule_skb->data, priv->multi_macs[i]); i++)
> >
> > Shouldn't this line be broken?
> >
>
> ok, thanks.
Also, since you're touching on those lines, could you please add an space
after 'if' (on the first hunk) and after 'for' (on the second one)?
>
> Regards
> >> ;
> >> if (i == priv->multi_num)
> >> drop = 1;
> >
> > WBR, Sergei
> >
> >
> >
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
Mauro
On 2014/1/7 21:54, Mauro Carvalho Chehab wrote:
> Em Thu, 26 Dec 2013 19:09:10 +0800
> Ding Tianhong <[email protected]> escreveu:
>
>> On 2013/12/25 18:57, Sergei Shtylyov wrote:
>>> Hello.
>>>
>>> On 25-12-2013 7:29, Ding Tianhong wrote:
>>>
>>>> Use possibly more efficient ether_addr_equal
>>>> instead of memcmp.
>>>
>>>> Cc: Mauro Carvalho Chehab <[email protected]>
>>>> Cc: [email protected]
>>>> Cc: [email protected]
>>>> Signed-off-by: Yang Yingliang <[email protected]>
>>>> Signed-off-by: Ding Tianhong <[email protected]>
>>>> ---
>>>> drivers/media/dvb-core/dvb_net.c | 8 ++++----
>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>>> diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
>>>> index f91c80c..3dfc33b 100644
>>>> --- a/drivers/media/dvb-core/dvb_net.c
>>>> +++ b/drivers/media/dvb-core/dvb_net.c
>>>> @@ -179,7 +179,7 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *skb,
>>>> eth = eth_hdr(skb);
>>>>
>>>> if (*eth->h_dest & 1) {
>>>> - if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0)
>>>> + if(ether_addr_equal(eth->h_dest,dev->broadcast))
>>>
>>> There should be space after comma.
>>>
>>>> @@ -674,11 +674,11 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len )
>>>> if (priv->rx_mode != RX_MODE_PROMISC) {
>>>> if (priv->ule_skb->data[0] & 0x01) {
>>>> /* multicast or broadcast */
>>>> - if (memcmp(priv->ule_skb->data, bc_addr, ETH_ALEN)) {
>>>> + if (!ether_addr_equal(priv->ule_skb->data, bc_addr)) {
>>>> /* multicast */
>>>> if (priv->rx_mode == RX_MODE_MULTI) {
>>>> int i;
>>>> - for(i = 0; i < priv->multi_num && memcmp(priv->ule_skb->data, priv->multi_macs[i], ETH_ALEN); i++)
>>>> + for(i = 0; i < priv->multi_num && !ether_addr_equal(priv->ule_skb->data, priv->multi_macs[i]); i++)
>>>
>>> Shouldn't this line be broken?
>>>
>>
>> ok, thanks.
>
> Also, since you're touching on those lines, could you please add an space
> after 'if' (on the first hunk) and after 'for' (on the second one)?
>
Ok, thanks
Regards
Ding
>>
>> Regards
>>>> ;
>>>> if (i == priv->multi_num)
>>>> drop = 1;
>>>
>>> WBR, Sergei
>>>
>>>
>>>
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Thanks,
> Mauro
>
> .
>