2014-01-09 11:10:05

by Jean-Francois Moine

Subject: [PATCH v2 6/28] drm/i2c: tda998x: force the page register at startup time

This patch forces the page register to be set on the first I/O operation.

Signed-off-by: Jean-Francois Moine <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 0435752..c29c0b1 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1162,7 +1162,7 @@ tda998x_encoder_init(struct i2c_client *client,
priv->vip_cntrl_1 = VIP_CNTRL_1_SWAP_C(0) | VIP_CNTRL_1_SWAP_D(1);
priv->vip_cntrl_2 = VIP_CNTRL_2_SWAP_E(4) | VIP_CNTRL_2_SWAP_F(5);

- priv->current_page = 0;
+ priv->current_page = 0xff;
priv->hdmi = client;
priv->cec = i2c_new_dummy(client->adapter, 0x34);
priv->dpms = DRM_MODE_DPMS_OFF;

--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/

2014-01-11 17:09:51

by Russell King - ARM Linux

Subject: Re: [PATCH v2 6/28] drm/i2c: tda998x: force the page register at startup time

On Thu, Jan 09, 2014 at 11:58:51AM +0100, Jean-Francois Moine wrote:
> This patch forces the page register to be set on the first I/O operation.
>
> Signed-off-by: Jean-Francois Moine <[email protected]>

No visible negative side effects, and nothing obviously wrong.

Tested-by: Russell King <[email protected]>
Acked-by: Russell King <[email protected]>

Thanks.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".