2014-01-09 11:17:32

by Jean-Francois Moine

[permalink] [raw]
Subject: [PATCH v2 14/28] drm/i2c: tda998x: get a better status of the connexion

This patch refines the connexion status testing both bits RXSENS and
HPD of the CEC register giving the connexion level.

Signed-off-by: Jean-Francois Moine <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 2187d63..0cae820 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1009,7 +1009,9 @@ tda998x_encoder_detect(struct drm_encoder *encoder,
struct tda998x_priv *priv = to_tda998x_priv(encoder);
uint8_t val = cec_read(priv, REG_CEC_RXSHPDLEV);

- return (val & CEC_RXSHPDLEV_HPD) ? connector_status_connected :
+ return (val & (CEC_RXSHPDLEV_RXSENS | CEC_RXSHPDLEV_HPD)) ==
+ (CEC_RXSHPDLEV_RXSENS | CEC_RXSHPDLEV_HPD) ?
+ connector_status_connected :
connector_status_disconnected;
}

--
Ken ar c'hentaƱ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/


2014-01-11 18:16:04

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH v2 14/28] drm/i2c: tda998x: get a better status of the connexion

On Thu, Jan 09, 2014 at 12:04:28PM +0100, Jean-Francois Moine wrote:
> This patch refines the connexion status testing both bits RXSENS and
> HPD of the CEC register giving the connexion level.

In English, it's spelt "connection" - there is no x, despite it sounding
like there is.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".