2014-01-09 11:09:50

by Jean-Francois Moine

Subject: [PATCH v2 4/28] drm/i2c: tda998x: change probe message origin

This patch gives a more precise information about the device getting the
TDA chip version.

Signed-off-by: Jean-Francois Moine <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index cd7ac58..63d5be2 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1187,12 +1187,21 @@ tda998x_encoder_init(struct i2c_client *client,
priv->rev &= ~0x30; /* not-hdcp and not-scalar bit */

switch (priv->rev) {
- case TDA9989N2: dev_info(dev->dev, "found TDA9989 n2"); break;
- case TDA19989: dev_info(dev->dev, "found TDA19989"); break;
- case TDA19989N2: dev_info(dev->dev, "found TDA19989 n2"); break;
- case TDA19988: dev_info(dev->dev, "found TDA19988"); break;
+ case TDA9989N2:
+ dev_info(&client->dev, "found TDA9989 n2");
+ break;
+ case TDA19989:
+ dev_info(&client->dev, "found TDA19989");
+ break;
+ case TDA19989N2:
+ dev_info(&client->dev, "found TDA19989 n2");
+ break;
+ case TDA19988:
+ dev_info(&client->dev, "found TDA19988");
+ break;
default:
- DBG("found unsupported device: %04x", priv->rev);
+ dev_err(&client->dev, "found unsupported device: %04x\n",
+ priv->rev);
goto fail;
}


--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/

2014-01-11 17:07:55

by Russell King - ARM Linux

Subject: Re: [PATCH v2 4/28] drm/i2c: tda998x: change probe message origin

On Thu, Jan 09, 2014 at 11:58:27AM +0100, Jean-Francois Moine wrote:
> This patch gives a more precise information about the device getting the
> TDA chip version.
>
> Signed-off-by: Jean-Francois Moine <[email protected]>

Acked-by: Russell King <[email protected]>
Tested-by: Russell King <[email protected]>

Please consider giving an example in the description of the old and new
in the above description. In other words:

armada-drm armada-510-drm: found TDA19988

becomes

tda998x 0-0070: found TDA19988

Thanks.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".