2014-01-09 11:10:44

by Jean-Francois Moine

Subject: [PATCH v2 10/28] drm/i2c: tda998x: free the CEC device on encoder_destroy

Signed-off-by: Jean-Francois Moine <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index c3f0d70..93ef64c 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1117,6 +1117,8 @@ tda998x_encoder_destroy(struct drm_encoder *encoder)
{
struct tda998x_priv *priv = to_tda998x_priv(encoder);
drm_i2c_encoder_destroy(encoder);
+ if (priv->cec)
+ i2c_unregister_device(priv->cec);
kfree(priv);
}

--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/

2014-01-11 17:24:28

by Russell King - ARM Linux

Subject: Re: [PATCH v2 10/28] drm/i2c: tda998x: free the CEC device on encoder_destroy

On Thu, Jan 09, 2014 at 11:59:56AM +0100, Jean-Francois Moine wrote:
>
> Signed-off-by: Jean-Francois Moine <[email protected]>

Simple enough two-liner, but a little more description is normally
desirable.

Tested-by: Russell King <[email protected]>
Acked-by: Russell King <[email protected]>

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".