2014-01-10 14:29:59

by Paul Gortmaker

[permalink] [raw]
Subject: [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c

Causing this:

In file included from arch/avr32/boards/mimc200/fram.c:13:
include/linux/miscdevice.h:51: error: field 'list' has incomplete type
include/linux/miscdevice.h:55: error: expected specifier-qualifier-list before 'mode_t'
arch/avr32/boards/mimc200/fram.c:42: error: 'THIS_MODULE' undeclared here (not in a function)

Reported-by: Fengguang Wu <[email protected]>
Cc: Haavard Skinnemoen <[email protected]>
Cc: Hans-Christian Egtvedt <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>

diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
index 9764a1a1073e..c1466a872b9c 100644
--- a/arch/avr32/boards/mimc200/fram.c
+++ b/arch/avr32/boards/mimc200/fram.c
@@ -11,6 +11,7 @@
#define FRAM_VERSION "1.0"

#include <linux/miscdevice.h>
+#include <linux/module.h>
#include <linux/proc_fs.h>
#include <linux/mm.h>
#include <linux/io.h>
--
1.8.5.2


Subject: Re: [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c

Around Fri 10 Jan 2014 09:29:39 -0500 or thereabout, Paul Gortmaker wrote:
> Causing this:
>
> In file included from arch/avr32/boards/mimc200/fram.c:13:
> include/linux/miscdevice.h:51: error: field 'list' has incomplete type
> include/linux/miscdevice.h:55: error: expected specifier-qualifier-list before 'mode_t'
> arch/avr32/boards/mimc200/fram.c:42: error: 'THIS_MODULE' undeclared here (not in a function)
>
> Reported-by: Fengguang Wu <[email protected]>
> Cc: Haavard Skinnemoen <[email protected]>
> Cc: Hans-Christian Egtvedt <[email protected]>
> Signed-off-by: Paul Gortmaker <[email protected]>

Thank you for fixing, almost identical to Sergei Trofimovich patch, which
appeared first in my inbox.

Fix appended to the AVR32 tree.

> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a1073e..c1466a872b9c 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -11,6 +11,7 @@
> #define FRAM_VERSION "1.0"
>
> #include <linux/miscdevice.h>
> +#include <linux/module.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> #include <linux/io.h>
--
mvh
Hans-Christian Egtvedt