2014-01-09 11:12:52

by Jean-Francois Moine

Subject: [PATCH v2 23/28] drm/i2c: tda998x: add the active aspect in HDMI AVI frame

This patch adds the active aspect as 'picture' in the HDMI AVI frame
and also some comments about this frame.

Signed-off-by: Jean-Francois Moine <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 55cecb8..68630b8 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -696,7 +696,11 @@ tda998x_write_avi(struct tda998x_priv *priv, struct drm_display_mode *mode)
buf[HB(1)] = 0x02;
buf[HB(2)] = HDMI_AVI_INFOFRAME_SIZE;
buf[PB(1)] = HDMI_SCAN_MODE_UNDERSCAN;
+ /* (color_ind << 5) | (info_pres << 4) | (bar << 2) | scan */
+ buf[PB(2)] = HDMI_ACTIVE_ASPECT_PICTURE;
+ /* (colorimetry << 6) | (pic_ratio << 4) | active_ratio */
buf[PB(3)] = HDMI_QUANTIZATION_RANGE_FULL << 2;
+ /* (quant_range << 2) | non_uniform_scaling */
buf[PB(4)] = drm_match_cea_mode(mode);

tda998x_write_if(priv, DIP_IF_FLAGS_IF2, REG_IF2_HB0, buf,
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/

2014-01-11 18:51:29

by Russell King - ARM Linux

Subject: Re: [PATCH v2 23/28] drm/i2c: tda998x: add the active aspect in HDMI AVI frame

On Thu, Jan 09, 2014 at 12:06:39PM +0100, Jean-Francois Moine wrote:
> This patch adds the active aspect as 'picture' in the HDMI AVI frame
> and also some comments about this frame.

Yes, this should've been set. It's probably a stable tree candidate,
but first it needs testing.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".

2014-01-13 09:26:59

by Jean-Francois Moine

Subject: Re: [PATCH v2 23/28] drm/i2c: tda998x: add the active aspect in HDMI AVI frame

On Sat, 11 Jan 2014 18:51:14 +0000
Russell King - ARM Linux <[email protected]> wrote:

> On Thu, Jan 09, 2014 at 12:06:39PM +0100, Jean-Francois Moine wrote:
> > This patch adds the active aspect as 'picture' in the HDMI AVI frame
> > and also some comments about this frame.
>
> Yes, this should've been set. It's probably a stable tree candidate,
> but first it needs testing.

I get correct 4:3 (1280x960) and 5:4 (1280x1024) images on my 16:9 TV
screen with this aspect value. 16:10 (1680x1050) images are stretched.

--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/