2014-01-03 16:41:03

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On 2013-12-23 22:56, Josh Triplett wrote:
> GCC 4.9 and newer have a new warning -Wdate-time, which warns on any use
> of __DATE__, __TIME__, or __TIMESTAMP__, which would make the build
> non-deterministic. Now that the kernel does not use any of those
> macros, turn on -Werror=date-time if available, to keep it that way.

Nice, I didn't know about -Wdate-time. Do you want me to merge the
entire series, or do you want individual maintainers merge the patches?
In the latter case, I'd wait with applying 7/7 in order not to break the
build. At any rate, you can add

Acked-by: Michal Marek <[email protected]>

Thanks,
Michal


2014-01-03 20:29:25

by Josh Triplett

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On Fri, Jan 03, 2014 at 05:40:52PM +0100, Michal Marek wrote:
> On 2013-12-23 22:56, Josh Triplett wrote:
> > GCC 4.9 and newer have a new warning -Wdate-time, which warns on any use
> > of __DATE__, __TIME__, or __TIMESTAMP__, which would make the build
> > non-deterministic. Now that the kernel does not use any of those
> > macros, turn on -Werror=date-time if available, to keep it that way.
>
> Nice, I didn't know about -Wdate-time. Do you want me to merge the
> entire series, or do you want individual maintainers merge the patches?
> In the latter case, I'd wait with applying 7/7 in order not to break the
> build. At any rate, you can add
>
> Acked-by: Michal Marek <[email protected]>

Please feel free to take the entire series through your tree; I received
some maintainer acks, but no indications that the patches are going
through their trees.

Patch 1 should have:
Reviewed-by: Jingoo Han <[email protected]>

and patch 3 should have:
Acked-by: Larry Finger <[email protected]>

Thanks,
Josh Triplett

2014-01-03 20:55:22

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On 3.1.2014 21:29, Josh Triplett wrote:
> Please feel free to take the entire series through your tree; I received
> some maintainer acks, but no indications that the patches are going
> through their trees.

OK. I will wait until mid next week and commit with any acks received.

Michal

2014-01-03 21:00:40

by Josh Triplett

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
> On 3.1.2014 21:29, Josh Triplett wrote:
> > Please feel free to take the entire series through your tree; I received
> > some maintainer acks, but no indications that the patches are going
> > through their trees.
>
> OK. I will wait until mid next week and commit with any acks received.

Thanks!

- Josh Triplett

2014-01-14 20:57:03

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

Dne 3.1.2014 22:00, Josh Triplett napsal(a):
> On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
>> On 3.1.2014 21:29, Josh Triplett wrote:
>>> Please feel free to take the entire series through your tree; I received
>>> some maintainer acks, but no indications that the patches are going
>>> through their trees.
>>
>> OK. I will wait until mid next week and commit with any acks received.
>
> Thanks!

I did not find time last week and Greg was faster and merged the driver
patches. But I'm reluctant to only merge the Makefile patch now, because
the kbuild branch would not build. I think I will send the patch to
Linus after 3.14-rc1.

Michal

2014-01-14 21:40:27

by Josh Triplett

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On Tue, Jan 14, 2014 at 09:56:53PM +0100, Michal Marek wrote:
> Dne 3.1.2014 22:00, Josh Triplett napsal(a):
> > On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
> >> On 3.1.2014 21:29, Josh Triplett wrote:
> >>> Please feel free to take the entire series through your tree; I received
> >>> some maintainer acks, but no indications that the patches are going
> >>> through their trees.
> >>
> >> OK. I will wait until mid next week and commit with any acks received.
> >
> > Thanks!
>
> I did not find time last week and Greg was faster and merged the driver
> patches. But I'm reluctant to only merge the Makefile patch now, because
> the kbuild branch would not build. I think I will send the patch to
> Linus after 3.14-rc1.

Greg, if you already have all the driver patches in your tree, perhaps
you could go ahead and take the Makefile patch through your tree as
well? (Assuming that's OK with you, Michal?)

- Josh Triplett

2014-01-14 21:45:40

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On Tue, Jan 14, 2014 at 01:40:15PM -0800, Josh Triplett wrote:
> On Tue, Jan 14, 2014 at 09:56:53PM +0100, Michal Marek wrote:
> > Dne 3.1.2014 22:00, Josh Triplett napsal(a):
> > > On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
> > >> On 3.1.2014 21:29, Josh Triplett wrote:
> > >>> Please feel free to take the entire series through your tree; I received
> > >>> some maintainer acks, but no indications that the patches are going
> > >>> through their trees.
> > >>
> > >> OK. I will wait until mid next week and commit with any acks received.
> > >
> > > Thanks!
> >
> > I did not find time last week and Greg was faster and merged the driver
> > patches. But I'm reluctant to only merge the Makefile patch now, because
> > the kbuild branch would not build. I think I will send the patch to
> > Linus after 3.14-rc1.
>
> Greg, if you already have all the driver patches in your tree, perhaps
> you could go ahead and take the Makefile patch through your tree as
> well? (Assuming that's OK with you, Michal?)

Did I really grab all of the other patches? I don't remember how many
there were in this series for stuff I maintain. If I have them all,
sure, I'll be glad to take it, otherwise I agree with Michal, it should
be sent to Linus after 3.14-rc1 is out to make sure everything is
properly synced up and you didn't miss any new drivers coming in that
missed getting converted.

thanks,

greg k-h

2014-01-27 22:57:39

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

On 14.1.2014 22:46, Greg KH wrote:
> On Tue, Jan 14, 2014 at 01:40:15PM -0800, Josh Triplett wrote:
>> On Tue, Jan 14, 2014 at 09:56:53PM +0100, Michal Marek wrote:
>>> Dne 3.1.2014 22:00, Josh Triplett napsal(a):
>>>> On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
>>>>> On 3.1.2014 21:29, Josh Triplett wrote:
>>>>>> Please feel free to take the entire series through your tree; I received
>>>>>> some maintainer acks, but no indications that the patches are going
>>>>>> through their trees.
>>>>>
>>>>> OK. I will wait until mid next week and commit with any acks received.
>>>>
>>>> Thanks!
>>>
>>> I did not find time last week and Greg was faster and merged the driver
>>> patches. But I'm reluctant to only merge the Makefile patch now, because
>>> the kbuild branch would not build. I think I will send the patch to
>>> Linus after 3.14-rc1.
>>
>> Greg, if you already have all the driver patches in your tree, perhaps
>> you could go ahead and take the Makefile patch through your tree as
>> well? (Assuming that's OK with you, Michal?)
>
> Did I really grab all of the other patches? I don't remember how many
> there were in this series for stuff I maintain. If I have them all,
> sure, I'll be glad to take it, otherwise I agree with Michal, it should
> be sent to Linus after 3.14-rc1 is out to make sure everything is
> properly synced up and you didn't miss any new drivers coming in that
> missed getting converted.

FYI: The remaining patches are now in the kbuild.git#drop-time branch
and also in the for-next branch.

Thanks,
Michal