2014-01-22 20:01:18

by Wim Van Sebroeck

[permalink] [raw]
Subject: Re: [PATCH] watchdog: mach-moxart: add restart handler

Hi Jonas,

> mach-moxart lacks a separate register for reset; as a workaround,
> add a function that can be hooked to arm_pm_restart.
>
> Signed-off-by: Jonas Jensen <[email protected]>

Added to linux-watchdog-next.

> ---
>
> Notes:
> During review of this driver, the restart handler for moxart was
> removed, and moved to platform code under arch/arm/mach-moxart/.
>
> Since then, new considerations arrived,
> see replies from Arnd and Guenter:
>
> "[PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files"
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/219175.html
>
> I can move this to a new power/restart driver, but first, I want to
> hear what Wim or others think.
>
> Until there is a better solution, my motivation is that this uses
> the watchdog. The way I see it, the problem is that there is no
> separate register for reset, this was always a workaround for that.
>
> Applies to next-20131218

Will review this again after the merge window is over.

Kind regards,
Wim.