2014-01-19 19:03:49

by Jean-Francois Moine

Subject: [PATCH v3 22/24] drm/i2c: tda998x: change the frequence in the audio channel

This patch sets the frequence as 'not indicated' instead of '48kHz'
and adds some comments.

Signed-off-by: Jean-Francois Moine <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 05713f7..2fcc432 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -745,10 +745,11 @@ tda998x_configure_audio(struct tda998x_priv *priv,
reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_RST_CTS);

/* Write the channel status */
- buf[0] = 0x04;
+ buf[0] = (1 << 2); /* copyright unprotected */
buf[1] = 0x00;
- buf[2] = 0x00;
- buf[3] = 0xf1;
+ buf[2] = 1; /* freq not indicated */
+ buf[3] = (0 << 4) | /* orig freq = not indicated */
+ 1; /* max word length 24 bits */
reg_write_range(priv, REG_CH_STAT_B(0), buf, 4);

tda998x_audio_mute(priv, true);
--
1.8.5.3

2014-01-22 23:52:12

by Russell King - ARM Linux

Subject: Re: [PATCH v3 22/24] drm/i2c: tda998x: change the frequence in the audio channel

On Sun, Jan 19, 2014 at 07:58:47PM +0100, Jean-Francois Moine wrote:
> This patch sets the frequence as 'not indicated' instead of '48kHz'
> and adds some comments.
>
> Signed-off-by: Jean-Francois Moine <[email protected]>

Good catch that byte 2 doesn't exist in this set.

sound/asounddef.h has definitions for these:

IEC958_AES0_CON_NOT_COPYRIGHT
IEC958_AES3_CON_FS_NOTID
IEC958_AES4_CON_MAX_WORDLEN_24
IEC958_AES4_CON_ORIGFS_NOTID

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".