2014-01-28 18:41:54

by Joe Perches

[permalink] [raw]
Subject: [PATCH] fmc: Fix decimal permissions

This 444 should have been octal.

Signed-off-by: Joe Perches <[email protected]>
---
drivers/fmc/fmc-write-eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fmc/fmc-write-eeprom.c b/drivers/fmc/fmc-write-eeprom.c
index 30e451e..1f107fb 100644
--- a/drivers/fmc/fmc-write-eeprom.c
+++ b/drivers/fmc/fmc-write-eeprom.c
@@ -26,7 +26,7 @@ FMC_PARAM_BUSID(fwe_drv);
/* The "file=" is like the generic "gateware=" used elsewhere */
static char *fwe_file[FMC_MAX_CARDS];
static int fwe_file_n;
-module_param_array_named(file, fwe_file, charp, &fwe_file_n, 444);
+module_param_array_named(file, fwe_file, charp, &fwe_file_n, 0444);

static int fwe_run_tlv(struct fmc_device *fmc, const struct firmware *fw,
int write)


2014-01-28 19:52:16

by Alessandro Rubini

[permalink] [raw]
Subject: Re: [PATCH] fmc: Fix decimal permissions

> This 444 should have been octal.

Right, my fault. We are not using the sysfs interface for module
parameters, so I didn't notice.

> Signed-off-by: Joe Perches <[email protected]>

Acked-by: Alessandro Rubini <[email protected]>

thanks
/alessandro, with two other minor fmc fixes to submit soon