2014-02-01 16:00:50

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 1/1] ext2: Add __init macro to init_inodecache

init_inodecache is only called by __init init_ext2_fs.

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/ext2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 20d6697..73d80da 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -192,7 +192,7 @@ static void init_once(void *foo)
inode_init_once(&ei->vfs_inode);
}

-static int init_inodecache(void)
+static int __init init_inodecache(void)
{
ext2_inode_cachep = kmem_cache_create("ext2_inode_cache",
sizeof(struct ext2_inode_info),
--
1.8.1.4


2014-02-01 17:53:37

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [PATCH 1/1] ext2: Add __init macro to init_inodecache

On Sat, Feb 01, 2014 at 04:02:02PM +0800, Fabian Frederick wrote:
> init_inodecache is only called by __init init_ext2_fs.

Looks like this is true for the majority of filesystems. Would you care
to submit more patches? :-)

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."

2014-02-01 18:18:27

by Fabian Frédérick

[permalink] [raw]
Subject: Re: [PATCH 1/1] ext2: Add __init macro to init_inodecache

On Sat, 1 Feb 2014 10:53:34 -0700
Matthew Wilcox <[email protected]> wrote:

> On Sat, Feb 01, 2014 at 04:02:02PM +0800, Fabian Frederick wrote:
> > init_inodecache is only called by __init init_ext2_fs.
>
> Looks like this is true for the majority of filesystems. Would you care
> to submit more patches? :-)
No problem ! Is it better to send separate patches like this one or one patch for all filesystems ?

>
> --
> Matthew Wilcox Intel Open Source Technology Centre
> "Bill, look, we understand that you're interested in selling us this
> operating system, but compare it to ours. We can't possibly take such
> a retrograde step."

2014-02-03 23:56:18

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH 1/1] ext2: Add __init macro to init_inodecache

On Sat 01-02-14 16:02:02, Fabian Frederick wrote:
> init_inodecache is only called by __init init_ext2_fs.
Thanks added to my tree.

Honza

>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 20d6697..73d80da 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -192,7 +192,7 @@ static void init_once(void *foo)
> inode_init_once(&ei->vfs_inode);
> }
>
> -static int init_inodecache(void)
> +static int __init init_inodecache(void)
> {
> ext2_inode_cachep = kmem_cache_create("ext2_inode_cache",
> sizeof(struct ext2_inode_info),
> --
> 1.8.1.4
>
--
Jan Kara <[email protected]>
SUSE Labs, CR