2014-01-31 12:48:04

by Richard Weinberger

Subject: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM

On archs like S390 or um this driver cannot build nor work.
Make it depend on HAS_IOMEM to bypass build failures.

drivers/built-in.o: In function `dw_wdt_drv_probe':
drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'

Signed-off-by: Richard Weinberger <[email protected]>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 4c4c566..79d2589 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -223,6 +223,7 @@ config SA1100_WATCHDOG

config DW_WATCHDOG
tristate "Synopsys DesignWare watchdog"
+ depends on HAS_IOMEM
help
Say Y here if to include support for the Synopsys DesignWare
watchdog timer found in many chips.
--
1.8.1.4

2014-02-03 08:58:09

by Wim Van Sebroeck

Subject: Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM

Hi Richard,

> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
>
> drivers/built-in.o: In function `dw_wdt_drv_probe':
> drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
>
> Signed-off-by: Richard Weinberger <[email protected]>

Patch added to linux-watchdog-next.

Kind regards,
Wim.

2014-02-03 09:13:56

by Richard Weinberger

Subject: Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM

Am 03.02.2014 09:58, schrieb Wim Van Sebroeck:
> Hi Richard,
>
>> On archs like S390 or um this driver cannot build nor work.
>> Make it depend on HAS_IOMEM to bypass build failures.
>>
>> drivers/built-in.o: In function `dw_wdt_drv_probe':
>> drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <[email protected]>
>
> Patch added to linux-watchdog-next.

-next in terms of 3.15 material?
Please push this as soon as possible to Linus such that the build works on said archs.

Thanks,
//richard

2014-02-03 10:39:15

by Wim Van Sebroeck

Subject: Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM

Hi Richard,

> >> On archs like S390 or um this driver cannot build nor work.
> >> Make it depend on HAS_IOMEM to bypass build failures.
> >>
> >> drivers/built-in.o: In function `dw_wdt_drv_probe':
> >> drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
> >>
> >> Signed-off-by: Richard Weinberger <[email protected]>
> >
> > Patch added to linux-watchdog-next.
>
> -next in terms of 3.15 material?
> Please push this as soon as possible to Linus such that the build works on said archs.

No, next in terms of a couple of days testing also.
This will go out before 3.14-rc2 is there.

Kind regards,
Wim.