2014-02-01 02:55:54

by Matthew Thode

[permalink] [raw]
Subject: mpt2sas driver barfs when force removing a drive on 3.13.1

I decided to pull a drive while it was in use out of laziness (it was
open via luks, but not in actual use). Got a fun trace as a result.
Just thought you'd like to know :D

The trace is attached

--
-- Matthew Thode (prometheanfire)


Attachments:
mpt2sas.trace (124.53 kB)
0x40AC5AC3.asc (5.46 kB)
signature.asc (836.00 B)
OpenPGP digital signature
Download all attachments

2014-02-03 15:03:55

by Joe Lawrence

[permalink] [raw]
Subject: Re: mpt2sas driver barfs when force removing a drive on 3.13.1

On Fri, 31 Jan 2014 20:49:39 -0600
Matthew Thode <[email protected]> wrote:

> I decided to pull a drive while it was in use out of laziness (it was
> open via luks, but not in actual use). Got a fun trace as a result.
> Just thought you'd like to know :D
>

Hi Matthew,

The first trace looks a lot like what I see on mpt2sas driver removal
[1]. I posted a suggested fix back in Dec [2], which you might try,
however it is not reviewed at this point.

[1] http://thread.gmane.org/gmane.linux.scsi/86237
[2] https://github.com/joe-lawrence/linux/compare/scsi_transport_sas_sysfs_warning.patch

Regards,

-- Joe

2014-02-12 11:59:50

by Reddy, Sreekanth

[permalink] [raw]
Subject: RE: mpt2sas driver barfs when force removing a drive on 3.13.1

Hi Joe,

May I known the status of this patch having subject
"[PATCH] scsi_transport_sas: move bsg destructor into sas_rphy_remove".

I need the status of this patch as I am also observing the same WARNING call trace on latest 3.14.0-rc2+ kernel whenever we unload the mpt2sas/mpt3sas driver or whenever we unplug the drive attached to the HBA.
But after applying yours patch, these WARNING call trace is not observed.

Regards,
Sreekanth

>-----Original Message-----
>From: Joe Lawrence [mailto:[email protected]]
>Sent: Monday, February 03, 2014 7:54 PM
>To: [email protected]
>Cc: Nandigama, Nagalakshmi; Reddy, Sreekanth; Support; DL-MPT Fusion
>Linux; [email protected]; [email protected]; linux-
>[email protected]; [email protected]
>Subject: Re: mpt2sas driver barfs when force removing a drive on 3.13.1
>
>On Fri, 31 Jan 2014 20:49:39 -0600
>Matthew Thode <[email protected]> wrote:
>
>> I decided to pull a drive while it was in use out of laziness (it was
>> open via luks, but not in actual use). Got a fun trace as a result.
>> Just thought you'd like to know :D
>>
>
>Hi Matthew,
>
>The first trace looks a lot like what I see on mpt2sas driver removal [1]. I
>posted a suggested fix back in Dec [2], which you might try, however it is not
>reviewed at this point.
>
>[1] http://thread.gmane.org/gmane.linux.scsi/86237
>[2] https://github.com/joe-
>lawrence/linux/compare/scsi_transport_sas_sysfs_warning.patch
>
>Regards,
>
>-- Joe


Attachments:
3.14.0-rc_module-remove.log (92.55 kB)
3.14.0-rc_module-remove.log

2014-02-12 16:56:14

by Joe Lawrence

[permalink] [raw]
Subject: Re: mpt2sas driver barfs when force removing a drive on 3.13.1

Hi Sreekanth,

There hasn't been much recent activity in
drivers/scsi/scsi_transport_sas.c, so I wasn't sure who could best
review the patch.

Dan Williams added sas_rphy_unlink() back in 2011, perhaps he can
remember why sas_bsg_remove wasn't performed there?

Regards,

-- Joe


On Wed, 12 Feb 2014 11:43:58 +0000
"Reddy, Sreekanth" <[email protected]> wrote:

> Hi Joe,
>
> May I known the status of this patch having subject
> "[PATCH] scsi_transport_sas: move bsg destructor into sas_rphy_remove".
>
> I need the status of this patch as I am also observing the same WARNING call trace on latest 3.14.0-rc2+ kernel whenever we unload the mpt2sas/mpt3sas driver or whenever we unplug the drive attached to the HBA.
> But after applying yours patch, these WARNING call trace is not observed.
>
> Regards,
> Sreekanth
>
> >-----Original Message-----
> >From: Joe Lawrence [mailto:[email protected]]
> >Sent: Monday, February 03, 2014 7:54 PM
> >To: [email protected]
> >Cc: Nandigama, Nagalakshmi; Reddy, Sreekanth; Support; DL-MPT Fusion
> >Linux; [email protected]; [email protected]; linux-
> >[email protected]; [email protected]
> >Subject: Re: mpt2sas driver barfs when force removing a drive on 3.13.1
> >
> >On Fri, 31 Jan 2014 20:49:39 -0600
> >Matthew Thode <[email protected]> wrote:
> >
> >> I decided to pull a drive while it was in use out of laziness (it was
> >> open via luks, but not in actual use). Got a fun trace as a result.
> >> Just thought you'd like to know :D
> >>
> >
> >Hi Matthew,
> >
> >The first trace looks a lot like what I see on mpt2sas driver removal [1]. I
> >posted a suggested fix back in Dec [2], which you might try, however it is not
> >reviewed at this point.
> >
> >[1] http://thread.gmane.org/gmane.linux.scsi/86237
> >[2] https://github.com/joe-
> >lawrence/linux/compare/scsi_transport_sas_sysfs_warning.patch
> >
> >Regards,
> >
> >-- Joe
>