2014-02-04 09:12:28

by Sachin Kamat

Subject: [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon

Semicolon is not necessary after the while statement.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/mfd/stmpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 42ccd0544513..4a91f6771fb8 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe)
if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET))
return 0;
usleep_range(100, 200);
- };
+ }
return -EIO;
}

--
1.7.9.5

2014-02-04 09:16:56

by Lee Jones

Subject: Re: [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon

> Semicolon is not necessary after the while statement.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/mfd/stmpe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 42ccd0544513..4a91f6771fb8 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe)
> if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET))
> return 0;
> usleep_range(100, 200);
> - };
> + }
> return -EIO;
> }

Can you re-submit with a new line between it and the return please?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2014-02-04 09:22:21

by Sachin Kamat

Subject: Re: [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon

On 4 February 2014 14:46, Lee Jones <[email protected]> wrote:
>> Semicolon is not necessary after the while statement.
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
>> ---
>> drivers/mfd/stmpe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
>> index 42ccd0544513..4a91f6771fb8 100644
>> --- a/drivers/mfd/stmpe.c
>> +++ b/drivers/mfd/stmpe.c
>> @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe)
>> if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET))
>> return 0;
>> usleep_range(100, 200);
>> - };
>> + }
>> return -EIO;
>> }
>
> Can you re-submit with a new line between it and the return please?

Sure. In a minute :)

--
With warm regards,
Sachin