2014-02-13 03:48:09

by Dave Jones

Subject: drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.

Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak
in the error path of tda998x_encoder_init

Picked up by the nightly Coverity scan. CID 1174076

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index fa18cf374470..faa77f543a07 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1151,8 +1151,10 @@ tda998x_encoder_init(struct i2c_client *client,

priv->current_page = 0xff;
priv->cec = i2c_new_dummy(client->adapter, 0x34);
- if (!priv->cec)
+ if (!priv->cec) {
+ kfree(priv);
return -ENODEV;
+ }
priv->dpms = DRM_MODE_DPMS_OFF;

encoder_slave->slave_priv = priv;

2014-02-13 19:46:14

by Russell King - ARM Linux

Subject: Re: drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.

On Wed, Feb 12, 2014 at 10:47:51PM -0500, Dave Jones wrote:
> Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak
> in the error path of tda998x_encoder_init
>
> Picked up by the nightly Coverity scan. CID 1174076
>
> Signed-off-by: Dave Jones <[email protected]>

Thanks Dave, patch applied, and will send to airlied soon.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".