2014-02-13 09:54:56

by Daeseok Youn

Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer

>From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Thu, 13 Feb 2014 17:16:36 +0900
Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer

following sparse warnings:

drivers/firmware/efi/efivars.c:230:66: warning:
Using plain integer as NULL pointer
drivers/firmware/efi/efi.c:236:27: warning:
Using plain integer as NULL pointer

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/firmware/efi/efi.c | 2 +-
drivers/firmware/efi/efivars.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 4753bac..d85187f 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -233,7 +233,7 @@ static __initdata efi_config_table_type_t common_tables[] =
{
{SAL_SYSTEM_TABLE_GUID, "SALsystab", &efi.sal_systab},
{SMBIOS_TABLE_GUID, "SMBIOS", &efi.smbios},
{UGA_IO_PROTOCOL_GUID, "UGA", &efi.uga},
- {NULL_GUID, NULL, 0},
+ {NULL_GUID, NULL, NULL},
};

static __init int match_config_table(efi_guid_t *guid,
diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
index 3dc2482..50ea412 100644
--- a/drivers/firmware/efi/efivars.c
+++ b/drivers/firmware/efi/efivars.c
@@ -227,7 +227,7 @@ efivar_store_raw(struct efivar_entry *entry, const char
*buf, size_t count)
memcpy(&entry->var, new_var, count);

err = efivar_entry_set(entry, new_var->Attributes,
- new_var->DataSize, new_var->Data, false);
+ new_var->DataSize, new_var->Data, NULL);
if (err) {
printk(KERN_WARNING "efivars: set_variable() failed: status=%d\n",
err);
return -EIO;
--
1.7.9.5

2014-02-13 11:06:32

by Matt Fleming

Subject: Re: [PATCH] firmware/efi : use NULL instead of 0 for pointer

On Thu, 13 Feb, at 06:54:48PM, Daeseok Youn wrote:
> From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Thu, 13 Feb 2014 17:16:36 +0900
> Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer
>
> following sparse warnings:
>
> drivers/firmware/efi/efivars.c:230:66: warning:
> Using plain integer as NULL pointer
> drivers/firmware/efi/efi.c:236:27: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---
> drivers/firmware/efi/efi.c | 2 +-
> drivers/firmware/efi/efivars.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply because it is corrupt,

fatal: corrupt patch at line 11
Patch failed at 0001 efi: Use NULL instead of 0 for pointer

Please attach the patch in a reply.

--
Matt Fleming, Intel Open Source Technology Center