2014-02-05 09:04:46

by Nishanth Menon

Subject: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done

omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
for every call that takes place. This is an can be done only if a change
is detected.

Signed-off-by: Nishanth Menon <[email protected]>
---
arch/arm/mach-omap2/dpll3xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
index 3185ced..d9bcbf7 100644
--- a/arch/arm/mach-omap2/dpll3xxx.c
+++ b/arch/arm/mach-omap2/dpll3xxx.c
@@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
* stuff is inherited for free
*/

- if (!ret)
+ if (!ret && clk_get_parent(hw->clk) != new_parent)
__clk_reparent(hw->clk, new_parent);

return 0;
--
1.7.9.5

2014-02-13 23:13:30

by Tony Lindgren

Subject: Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done

* Nishanth Menon <[email protected]> [140205 01:06]:
> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
> for every call that takes place. This is an can be done only if a change
> is detected.
>
> Signed-off-by: Nishanth Menon <[email protected]>

Would like to see acks on this too before applying.

Tony

> ---
> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
> index 3185ced..d9bcbf7 100644
> --- a/arch/arm/mach-omap2/dpll3xxx.c
> +++ b/arch/arm/mach-omap2/dpll3xxx.c
> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
> * stuff is inherited for free
> */
>
> - if (!ret)
> + if (!ret && clk_get_parent(hw->clk) != new_parent)
> __clk_reparent(hw->clk, new_parent);
>
> return 0;
> --
> 1.7.9.5
>

2014-02-14 13:14:16

by Tero Kristo

Subject: Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done

On 02/14/2014 01:13 AM, Tony Lindgren wrote:
> * Nishanth Menon <[email protected]> [140205 01:06]:
>> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
>> for every call that takes place. This is an can be done only if a change
>> is detected.
>>
>> Signed-off-by: Nishanth Menon <[email protected]>
>
> Would like to see acks on this too before applying.

Looks good to me, ack.

-Tero

>
> Tony
>
>> ---
>> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
>> index 3185ced..d9bcbf7 100644
>> --- a/arch/arm/mach-omap2/dpll3xxx.c
>> +++ b/arch/arm/mach-omap2/dpll3xxx.c
>> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
>> * stuff is inherited for free
>> */
>>
>> - if (!ret)
>> + if (!ret && clk_get_parent(hw->clk) != new_parent)
>> __clk_reparent(hw->clk, new_parent);
>>
>> return 0;
>> --
>> 1.7.9.5
>>

2014-02-20 03:04:57

by Paul Walmsley

Subject: Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done

On Wed, 5 Feb 2014, Nishanth Menon wrote:

> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
> for every call that takes place. This is an can be done only if a change
> is detected.
>
> Signed-off-by: Nishanth Menon <[email protected]>

Queued for v3.15 with Tero's ack unless the patch is updated to indicate
that it's more than an optimization.


- Paul