2014-02-17 05:09:41

by Jiang Liu

Subject: [PATCH] sb_edac: degrade log level for "EDAC sbridge: Seeking for: dev 1d.3 PCI ID xxxx"

On a system with four Intel processor, it generates too many messages
"EDAC sbridge: Seeking for: dev 1d.3 PCI ID xxxx". And it doesn't
give many useful information for normal users, so change log level
from INFO to DEBUG.

Signed-off-by: Jiang Liu <[email protected]>
---
drivers/edac/sb_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 54e2abe..347c7a1 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -1263,7 +1263,7 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
struct pci_dev *pdev = NULL;
u8 bus = 0;

- sbridge_printk(KERN_INFO,
+ sbridge_printk(KERN_DEBUG,
"Seeking for: dev %02x.%d PCI ID %04x:%04x\n",
dev_descr->dev, dev_descr->func,
PCI_VENDOR_ID_INTEL, dev_descr->dev_id);
--
1.7.10.4

2014-02-17 14:32:43

by Aristeu Rozanski

Subject: Re: [PATCH] sb_edac: degrade log level for "EDAC sbridge: Seeking for: dev 1d.3 PCI ID xxxx"

On Mon, Feb 17, 2014 at 01:10:23PM +0800, Jiang Liu wrote:
> On a system with four Intel processor, it generates too many messages
> "EDAC sbridge: Seeking for: dev 1d.3 PCI ID xxxx". And it doesn't
> give many useful information for normal users, so change log level
> from INFO to DEBUG.
>
> Signed-off-by: Jiang Liu <[email protected]>
> ---
> drivers/edac/sb_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 54e2abe..347c7a1 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -1263,7 +1263,7 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
> struct pci_dev *pdev = NULL;
> u8 bus = 0;
>
> - sbridge_printk(KERN_INFO,
> + sbridge_printk(KERN_DEBUG,
> "Seeking for: dev %02x.%d PCI ID %04x:%04x\n",
> dev_descr->dev, dev_descr->func,
> PCI_VENDOR_ID_INTEL, dev_descr->dev_id);

ACK

--
Aristeu

2014-02-20 10:49:46

by Borislav Petkov

Subject: Re: [PATCH] sb_edac: degrade log level for "EDAC sbridge: Seeking for: dev 1d.3 PCI ID xxxx"

On Mon, Feb 17, 2014 at 09:32:36AM -0500, Aristeu Rozanski wrote:
> On Mon, Feb 17, 2014 at 01:10:23PM +0800, Jiang Liu wrote:
> > On a system with four Intel processor, it generates too many messages
> > "EDAC sbridge: Seeking for: dev 1d.3 PCI ID xxxx". And it doesn't
> > give many useful information for normal users, so change log level
> > from INFO to DEBUG.
> >
> > Signed-off-by: Jiang Liu <[email protected]>
> > ---
> > drivers/edac/sb_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> > index 54e2abe..347c7a1 100644
> > --- a/drivers/edac/sb_edac.c
> > +++ b/drivers/edac/sb_edac.c
> > @@ -1263,7 +1263,7 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
> > struct pci_dev *pdev = NULL;
> > u8 bus = 0;
> >
> > - sbridge_printk(KERN_INFO,
> > + sbridge_printk(KERN_DEBUG,
> > "Seeking for: dev %02x.%d PCI ID %04x:%04x\n",
> > dev_descr->dev, dev_descr->func,
> > PCI_VENDOR_ID_INTEL, dev_descr->dev_id);
>
> ACK

Applied, thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--