2014-02-19 05:11:24

by Daeseok Youn

Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer

>From 932e928d53b1e588dc17019e7f9fa7a61b8b7468 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 10:35:41 +0900
Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer

sparse says:

drivers/atm/ambassador.c:1928:24: warning:
Using plain integer as NULL pointer

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/atm/ambassador.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 62a7607..f1a9198 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -1925,7 +1925,7 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
const struct firmware *fw;
unsigned long start_address;
const struct ihex_binrec *rec;
- const char *errmsg = 0;
+ const char *errmsg = NULL;
int res;

res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);
--
1.7.9.5
---

2014-02-19 14:59:43

by chas williams - CONTRACTOR

Subject: Re: [PATCH] atm: ambassador: use NULL instead of 0 for pointer

On Wed, 19 Feb 2014 14:11:15 +0900
Daeseok Youn <[email protected]> wrote:

> >From 932e928d53b1e588dc17019e7f9fa7a61b8b7468 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 10:35:41 +0900
> Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/atm/ambassador.c:1928:24: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---
> drivers/atm/ambassador.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 62a7607..f1a9198 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1925,7 +1925,7 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
> const struct firmware *fw;
> unsigned long start_address;
> const struct ihex_binrec *rec;
> - const char *errmsg = 0;
> + const char *errmsg = NULL;
> int res;
>
> res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);

Acked-by: Chas Williams <[email protected]>

2014-02-19 21:39:45

by David Miller

Subject: Re: [PATCH] atm: ambassador: use NULL instead of 0 for pointer

From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 14:11:15 +0900

> From 932e928d53b1e588dc17019e7f9fa7a61b8b7468 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 10:35:41 +0900
> Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/atm/ambassador.c:1928:24: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <[email protected]>

Applied.