2014-02-19 05:14:04

by Daeseok Youn

Subject: [PATCH] atm: solos-pci: make solos_bh() as static

>From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 10:49:12 +0900
Subject: [PATCH] atm: solos-pci: make solos_bh() as static

sparse says:

drivers/atm/solos-pci.c:763:6: warning:
symbol 'solos_bh' was not declared. Should it be static?

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/atm/solos-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index e3fb496..943cf0d 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -760,7 +760,7 @@ static irqreturn_t solos_irq(int irq, void *dev_id)
return IRQ_RETVAL(handled);
}

-void solos_bh(unsigned long card_arg)
+static void solos_bh(unsigned long card_arg)
{
struct solos_card *card = (void *)card_arg;
uint32_t card_flags;
--
1.7.9.5

2014-02-19 14:59:00

by chas williams - CONTRACTOR

Subject: Re: [PATCH] atm: solos-pci: make solos_bh() as static

On Wed, 19 Feb 2014 14:13:54 +0900
Daeseok Youn <[email protected]> wrote:

> >From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 10:49:12 +0900
> Subject: [PATCH] atm: solos-pci: make solos_bh() as static
>
> sparse says:
>
> drivers/atm/solos-pci.c:763:6: warning:
> symbol 'solos_bh' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---
> drivers/atm/solos-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index e3fb496..943cf0d 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -760,7 +760,7 @@ static irqreturn_t solos_irq(int irq, void *dev_id)
> return IRQ_RETVAL(handled);
> }
>
> -void solos_bh(unsigned long card_arg)
> +static void solos_bh(unsigned long card_arg)
> {
> struct solos_card *card = (void *)card_arg;
> uint32_t card_flags;

Acked-by: Chas Williams <[email protected]>

2014-02-19 21:39:58

by David Miller

Subject: Re: [PATCH] atm: solos-pci: make solos_bh() as static

From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 14:13:54 +0900

> From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 10:49:12 +0900
> Subject: [PATCH] atm: solos-pci: make solos_bh() as static
>
> sparse says:
>
> drivers/atm/solos-pci.c:763:6: warning:
> symbol 'solos_bh' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <[email protected]>

Applied.