2014-02-22 15:00:28

by Christian Engelmayer

[permalink] [raw]
Subject: [PATCH] ASoC: wm8993: Remove unused pointer in wm8993_remove()

Commit 88b5bdfd (ASoC: wm8993: drop regulator_bulk_free of devm_ allocated
data) eliminated the last user of driver data pointer 'wm8993' in function
wm8993_remove() - Thus remove it. Detected by Coverity: CID 1186208.

Signed-off-by: Christian Engelmayer <[email protected]>
---
Applies against branch for-next in tree
git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
---
sound/soc/codecs/wm8993.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c
index 2ee23a3..f7978b3 100644
--- a/sound/soc/codecs/wm8993.c
+++ b/sound/soc/codecs/wm8993.c
@@ -1559,8 +1559,6 @@ static int wm8993_probe(struct snd_soc_codec *codec)

static int wm8993_remove(struct snd_soc_codec *codec)
{
- struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
-
wm8993_set_bias_level(codec, SND_SOC_BIAS_OFF);
return 0;
}
--
1.8.3.2


Attachments:
signature.asc (836.00 B)

2014-02-25 04:35:25

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: wm8993: Remove unused pointer in wm8993_remove()

On Sat, Feb 22, 2014 at 04:00:16PM +0100, Christian Engelmayer wrote:
> Commit 88b5bdfd (ASoC: wm8993: drop regulator_bulk_free of devm_ allocated
> data) eliminated the last user of driver data pointer 'wm8993' in function
> wm8993_remove() - Thus remove it. Detected by Coverity: CID 1186208.

Applied, thanks.


Attachments:
(No filename) (313.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments