2014-02-21 13:19:47

by Johannes Berg

Subject: [PATCH 3.14] power_supply: don't export power_supply_notifier

From: Johannes Berg <[email protected]>

Since there are registration/unregistration functions and the
invocation is in the core code, there's no need to export the
notifier chain head, make it static instead.

Signed-off-by: Johannes Berg <[email protected]>
---
This should probably go into 3.14 so it's not exported in the release.
---
drivers/power/power_supply_core.c | 3 +--
include/linux/power_supply.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c
index 26606641fe44..31a105235c3e 100644
--- a/drivers/power/power_supply_core.c
+++ b/drivers/power/power_supply_core.c
@@ -25,8 +25,7 @@
struct class *power_supply_class;
EXPORT_SYMBOL_GPL(power_supply_class);

-ATOMIC_NOTIFIER_HEAD(power_supply_notifier);
-EXPORT_SYMBOL_GPL(power_supply_notifier);
+static ATOMIC_NOTIFIER_HEAD(power_supply_notifier);

static struct device_type power_supply_dev_type;

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index c9dc4e09854c..80968ee25940 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -240,7 +240,6 @@ struct power_supply_info {
int use_for_apm;
};

-extern struct atomic_notifier_head power_supply_notifier;
extern int power_supply_reg_notifier(struct notifier_block *nb);
extern void power_supply_unreg_notifier(struct notifier_block *nb);
extern struct power_supply *power_supply_get_by_name(const char *name);
--
1.8.5.3

2014-02-25 11:37:58

by Tc, Jenny

Subject: Re: [PATCH 3.14] power_supply: don't export power_supply_notifier

On Fri, Feb 21, 2014 at 02:19:28PM +0100, Johannes Berg wrote:
> From: Johannes Berg <[email protected]>
>
> Since there are registration/unregistration functions and the
> invocation is in the core code, there's no need to export the
> notifier chain head, make it static instead.

This is a generic notifier which can be used outside power_supply_core.c
to post psy events as in patch
power_supply-Introduce-generic-psy-charging-driver.patch. So the notifier chain
need to be exported.