2014-02-28 02:21:14

by Kumar Amit Mehta

Subject: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access

'struct tty_struct’ has no member named ‘low_latency’

Signed-off-by: Kumar Amit Mehta <[email protected]>
---
drivers/staging/sb105x/sb_pci_mp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c
index c9d6ee3..5687d6c 100644
--- a/drivers/staging/sb105x/sb_pci_mp.c
+++ b/drivers/staging/sb105x/sb_pci_mp.c
@@ -898,7 +898,7 @@ static int mp_set_info(struct sb_uart_state *state, struct serial_struct *newinf
state->closing_wait = closing_wait;
port->fifosize = new_serial.xmit_fifo_size;
if (state->info->tty)
- state->info->tty->low_latency =
+ state->info->tty->port->low_latency =
(port->flags & UPF_LOW_LATENCY) ? 1 : 0;

check_and_exit:
@@ -1571,7 +1571,7 @@ static int mp_open(struct tty_struct *tty, struct file *filp)
mtpt = (struct mp_port *)state->port;

tty->driver_data = state;
- tty->low_latency = (state->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
+ tty->port->low_latency = (state->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
tty->alt_speed = 0;
state->info->tty = tty;

--
1.8.5.3

2014-02-28 22:19:04

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access

On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote:
> 'struct tty_struct’ has no member named ‘low_latency’

This driver is marked BROKEN, and can't even compile, how did you test
this patch?

2014-02-28 22:22:26

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access

On Fri, Feb 28, 2014 at 02:20:40PM -0800, Greg KH wrote:
> On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote:
> > 'struct tty_struct’ has no member named ‘low_latency’
>
> This driver is marked BROKEN, and can't even compile, how did you test
> this patch?

Don't worry about it anymore, I've now deleted the driver entirely, as
no one has cared about it in the past year that it has been disabled
from the kernel build.

thanks,

greg k-h