2014-04-01 05:34:29

by Steffen Trumtrar

Subject: Re: [PATCH 2/2] arm: socfpga: Add support for Altera SoC SDRAM controller

On Mon, Mar 31, 2014 at 05:07:07PM -0500, [email protected] wrote:
> From: Thor Thayer <[email protected]>
>
> Addition of the Altera SDRAM controller registers to the
> Altera SoC project. These registers are shared by future
> drivers such as ECC and the FPGA bridge.
>
> Signed-off-by: Thor Thayer <[email protected]>
> To: Rob Herring <[email protected]>
> To: Pawel Moll <[email protected]>
> To: Mark Rutland <[email protected]>
> To: Ian Campbell <[email protected]>
> To: Kumar Gala <[email protected]>
> To: Rob Landley <[email protected]>
> To: Russell King <[email protected]>
> To: Dinh Nguyen <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> arch/arm/mach-socfpga/socfpga.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> index 21d6026..d514e8a 100644
> --- a/arch/arm/mach-socfpga/socfpga.c
> +++ b/arch/arm/mach-socfpga/socfpga.c
> @@ -32,6 +32,7 @@
> void __iomem *socfpga_scu_base_addr = ((void __iomem *)(SOCFPGA_SCU_VIRT_BASE));
> void __iomem *sys_manager_base_addr;
> void __iomem *rst_manager_base_addr;
> +void __iomem *sdr_ctl_base_addr;
> void __iomem *clk_mgr_base_addr;
> unsigned long cpu1start_addr;
>

Can't we get rid of all these global pointers instead of adding to them?

> @@ -150,6 +151,15 @@ void __init socfpga_sysmgr_init(void)
>
> np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr");
> clk_mgr_base_addr = of_iomap(np, 0);
> +
> + np = of_find_compatible_node(NULL, NULL, "altr,sdr-ctl");
> + if (!np) {
> + pr_err("SOCFPGA: Unable to find sdr-ctl\n");
> + return;
> + }
> +
> + sdr_ctl_base_addr = of_iomap(np, 0);
> + WARN_ON(!sdr_ctl_base_addr);
> }
>
> static void __init socfpga_init_irq(void)
> --
> 1.7.9.5
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2014-04-01 19:59:52

by Thor Thayer

Subject: Re: [PATCH 2/2] arm: socfpga: Add support for Altera SoC SDRAM controller

On Tue, 2014-04-01 at 07:33 +0200, Steffen Trumtrar wrote:
> On Mon, Mar 31, 2014 at 05:07:07PM -0500, [email protected] wrote:
> > From: Thor Thayer <[email protected]>
> >
<snip>
> >
>
> Can't we get rid of all these global pointers instead of adding to them?

Yes. I will remove this file from the patch. Thanks.

>
> > @@ -150,6 +151,15 @@ void __init socfpga_sysmgr_init(void)
> >
> > np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr");
> > clk_mgr_base_addr = of_iomap(np, 0);
> > +
> > + np = of_find_compatible_node(NULL, NULL, "altr,sdr-ctl");
> > + if (!np) {
> > + pr_err("SOCFPGA: Unable to find sdr-ctl\n");
> > + return;
> > + }
> > +
> > + sdr_ctl_base_addr = of_iomap(np, 0);
> > + WARN_ON(!sdr_ctl_base_addr);
> > }
> >
> > static void __init socfpga_init_irq(void)
> > --
> > 1.7.9.5
> >
>