2014-04-01 06:12:21

by Sascha Hauer

[permalink] [raw]
Subject: Re: [RFC 0/5] of: Automatic console registration cleanups

On Mon, Mar 31, 2014 at 10:41:24AM +0100, Grant Likely wrote:
> On Mon, 31 Mar 2014 09:10:15 +0200, Sascha Hauer <[email protected]> wrote:
> > On Fri, Mar 28, 2014 at 09:08:00AM -0700, Grant Likely wrote:
> > > Hi all,
> > >
> > > This is a series that I've been playing with over the last few days to
> > > clean up the selection of default console devices when using the device
> > > tree. The device tree defines a way of specifying the console by using a
> > > "stdout-path" property in the /chosen node, but very few drivers
> > > actually attempt to use that data, and so for most platforms there needs
> > > to be a "console=" line in the command line if a serial port is intended
> > > to be used as the console.
> > >
> > > With this series, if there is a /chosen/stdout-path property, and if
> > > that property points to a serial port node, then when the serial driver
> > > registers the port, the core uart_add_one_port() function will notice
> > > and if no console= argument was provided then add it as a preferred
> > > console.
> > >
> > > I've not tested this very extensively yet, but I want to get some
> > > feedback before I go further.
> >
> > I gave it a test on i.MX. It works as expected with both
> > linux,stdout-path and stdout-path. Specifying a console on the
> > commandline still works and overrides the devicetree setting.
> >
> > Tested-by: Sascha Hauer <[email protected]>
>
> Brilliant! Thanks Sascha.
>
> Can you supply a patch to add stdout to the imx dts files?

The information which console is used on each board is not in the
kernel. I can create a patch adding stdout for a handful of boards I
know, but I won't catch all.

Sascha

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


2014-04-01 09:08:58

by Grant Likely

[permalink] [raw]
Subject: Re: [RFC 0/5] of: Automatic console registration cleanups

On Tue, 1 Apr 2014 08:12:16 +0200, Sascha Hauer <[email protected]> wrote:
> On Mon, Mar 31, 2014 at 10:41:24AM +0100, Grant Likely wrote:
> > On Mon, 31 Mar 2014 09:10:15 +0200, Sascha Hauer <[email protected]> wrote:
> > > On Fri, Mar 28, 2014 at 09:08:00AM -0700, Grant Likely wrote:
> > > > Hi all,
> > > >
> > > > This is a series that I've been playing with over the last few days to
> > > > clean up the selection of default console devices when using the device
> > > > tree. The device tree defines a way of specifying the console by using a
> > > > "stdout-path" property in the /chosen node, but very few drivers
> > > > actually attempt to use that data, and so for most platforms there needs
> > > > to be a "console=" line in the command line if a serial port is intended
> > > > to be used as the console.
> > > >
> > > > With this series, if there is a /chosen/stdout-path property, and if
> > > > that property points to a serial port node, then when the serial driver
> > > > registers the port, the core uart_add_one_port() function will notice
> > > > and if no console= argument was provided then add it as a preferred
> > > > console.
> > > >
> > > > I've not tested this very extensively yet, but I want to get some
> > > > feedback before I go further.
> > >
> > > I gave it a test on i.MX. It works as expected with both
> > > linux,stdout-path and stdout-path. Specifying a console on the
> > > commandline still works and overrides the devicetree setting.
> > >
> > > Tested-by: Sascha Hauer <[email protected]>
> >
> > Brilliant! Thanks Sascha.
> >
> > Can you supply a patch to add stdout to the imx dts files?
>
> The information which console is used on each board is not in the
> kernel. I can create a patch adding stdout for a handful of boards I
> know, but I won't catch all.

That's all I'm asking for. I don't expect all platforms.

g.