2014-04-01 12:38:39

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regmap: mmio: Fix the bug of 'offset' value parsing.

On Mon, Mar 31, 2014 at 02:33:31PM +0800, Xiubo Li wrote:
> 'offset = *(u32 *)reg;', this will be okey for 32/64-bit register, but
> for 8/16-bit register, the 'offset' value will overflow.

This doesn't apply against regmap-v3.15, please check and resend.

> The core trace:
> ===============
> Unable to handle kernel paging request at virtual address ffbd0000
> pgd = 871e8000
> [ffbd0000] *pgd=00000000
> Internal error: Oops: 805 [#1] ARM
> Modules linked in:
> CPU: 0 PID: 1004 Comm: sh Not tainted 3.14.0-rc6+ #990
> task: 871baa40 ti: 87090000 task.ti: 87090000

Don't paste entire backtraces into commit messages, they're enormous and
most of the detail isn't useful making it easy to miss relevant
information - either pick relevant sections or just describe the
failure.


Attachments:
(No filename) (782.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2014-04-02 03:13:40

by Xiubo Li

[permalink] [raw]
Subject: RE: [PATCH] regmap: mmio: Fix the bug of 'offset' value parsing.

> Subject: Re: [PATCH] regmap: mmio: Fix the bug of 'offset' value parsing.
>
> On Mon, Mar 31, 2014 at 02:33:31PM +0800, Xiubo Li wrote:
> > 'offset = *(u32 *)reg;', this will be okey for 32/64-bit register, but
> > for 8/16-bit register, the 'offset' value will overflow.
>
> This doesn't apply against regmap-v3.15, please check and resend.
>
> > The core trace:
> > ===============
> > Unable to handle kernel paging request at virtual address ffbd0000
> > pgd = 871e8000
> > [ffbd0000] *pgd=00000000
> > Internal error: Oops: 805 [#1] ARM
> > Modules linked in:
> > CPU: 0 PID: 1004 Comm: sh Not tainted 3.14.0-rc6+ #990
> > task: 871baa40 ti: 87090000 task.ti: 87090000
>
> Don't paste entire backtraces into commit messages, they're enormous and
> most of the detail isn't useful making it easy to miss relevant
> information - either pick relevant sections or just describe the
> failure.

Yes, I have resent this patch and have fixed the issue that you pointed out.

Thanks :)
--

Best Regards,
Xiubo