2014-04-02 15:24:08

by Josh Boyer

Subject: [PATCH] net: enic: include irq.h for irqreturn_t definitions

The enic driver fails to build on ARM with:

In file included from drivers/net/ethernet/cisco/enic/enic_res.c:40:0:
drivers/net/ethernet/cisco/enic/enic.h:48:2: error: expected specifier-qualifier-list before 'irqreturn_t'
irqreturn_t (*isr)(int, void *);
^

Nothing in the driver is explicitly including the irq definitions, so we add
an include of linux/irq.h to pick them up.

Signed-off-by: Josh Boyer <[email protected]>
---
drivers/net/ethernet/cisco/enic/enic.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/cisco/enic/enic.h
index e9f7c656ddda..e35c8e0202ad 100644
--- a/drivers/net/ethernet/cisco/enic/enic.h
+++ b/drivers/net/ethernet/cisco/enic/enic.h
@@ -29,6 +29,7 @@
#include "vnic_stats.h"
#include "vnic_nic.h"
#include "vnic_rss.h"
+#include <linux/irq.h>

#define DRV_NAME "enic"
#define DRV_DESCRIPTION "Cisco VIC Ethernet NIC Driver"
--
1.8.5.3

2014-04-03 18:03:35

by David Miller

Subject: Re: [PATCH] net: enic: include irq.h for irqreturn_t definitions

From: Josh Boyer <[email protected]>
Date: Wed, 2 Apr 2014 11:24:00 -0400

> The enic driver fails to build on ARM with:
>
> In file included from drivers/net/ethernet/cisco/enic/enic_res.c:40:0:
> drivers/net/ethernet/cisco/enic/enic.h:48:2: error: expected specifier-qualifier-list before 'irqreturn_t'
> irqreturn_t (*isr)(int, void *);
> ^
>
> Nothing in the driver is explicitly including the irq definitions, so we add
> an include of linux/irq.h to pick them up.
>
> Signed-off-by: Josh Boyer <[email protected]>

Applied.