2014-04-11 08:40:05

by Duan Jiong

[permalink] [raw]
Subject: [PATCH] PHY: sunxi: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

This patch fixes coccinelle error regarding usage of IS_ERR and
PTR_ERR instead of PTR_ERR_OR_ZERO.

Signed-off-by: Duan Jiong <[email protected]>
---
drivers/phy/phy-sun4i-usb.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index e6e6c4b..f7bffe2 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -302,10 +302,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)

dev_set_drvdata(dev, data);
phy_provider = devm_of_phy_provider_register(dev, sun4i_usb_phy_xlate);
- if (IS_ERR(phy_provider))
- return PTR_ERR(phy_provider);
-
- return 0;
+ return PTR_ERR_OR_ZERO(phy_provider);
}

static const struct of_device_id sun4i_usb_phy_of_match[] = {
--
1.8.3.1


2014-04-14 10:00:05

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] PHY: sunxi: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

On Fri, Apr 11, 2014 at 04:38:03PM +0800, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Signed-off-by: Duan Jiong <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

You should probably send it to Kishon so that he can merge it though.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


Attachments:
(No filename) (478.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments