2014-04-22 05:20:05

by Fabian Frédérick

Subject: [PATCH RESEND] fs/bio.c: remove nr_segs (unused function parameter)

nr_segs is no longer used in bio_alloc_map_data since

c8db444820a1e3 ("block: Don't save/copy bvec array anymore")

Cc: Alexander Viro <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
fs/bio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/bio.c b/fs/bio.c
index 6f0362b..bd39c5b 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -1011,8 +1011,7 @@ static void bio_set_map_data(struct bio_map_data *bmd, struct bio *bio,
bio->bi_private = bmd;
}

-static struct bio_map_data *bio_alloc_map_data(int nr_segs,
- unsigned int iov_count,
+static struct bio_map_data *bio_alloc_map_data(unsigned int iov_count,
gfp_t gfp_mask)
{
if (iov_count > UIO_MAXIOV)
@@ -1154,7 +1153,7 @@ struct bio *bio_copy_user_iov(struct request_queue *q,
if (offset)
nr_pages++;

- bmd = bio_alloc_map_data(nr_pages, iov_count, gfp_mask);
+ bmd = bio_alloc_map_data(iov_count, gfp_mask);
if (!bmd)
return ERR_PTR(-ENOMEM);

--
1.8.4.5

2014-04-22 21:11:45

by Jens Axboe

Subject: Re: [PATCH RESEND] fs/bio.c: remove nr_segs (unused function parameter)

On 04/21/2014 11:21 PM, Fabian Frederick wrote:
> nr_segs is no longer used in bio_alloc_map_data since

Thanks, applied this one and your biovec_create_pool() patch for 3.16.

--
Jens Axboe