2014-04-22 14:23:44

by Drew Richardson

Subject: [PATCH] Export block tracepoints for use by kernel modules

After commit de7b2973903c6cc50b31ee5682a69b2219b9919d ("tracepoint:
Use struct pointer instead of name hash for reg/unreg tracepoints"),
any tracepoints used in a kernel module must be exported.

Signed-off-by: Drew Richardson <[email protected]>
Acked-by: Pawel Moll <[email protected]>
---
block/blk-core.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/block/blk-core.c b/block/blk-core.c
index a0e3096c4bb5..a23f958ef20a 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -44,6 +44,21 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_remap);
EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_remap);
EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_complete);
EXPORT_TRACEPOINT_SYMBOL_GPL(block_unplug);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_touch_buffer);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_dirty_buffer);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_abort);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_requeue);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_complete);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_insert);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_issue);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_bounce);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_backmerge);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_frontmerge);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_queue);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_getrq);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_sleeprq);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_plug);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_split);

DEFINE_IDA(blk_queue_ida);

--
1.8.3.2

2014-04-22 16:01:20

by Christoph Hellwig

Subject: Re: [PATCH] Export block tracepoints for use by kernel modules

On Tue, Apr 22, 2014 at 07:23:41AM -0700, Drew Richardson wrote:
> After commit de7b2973903c6cc50b31ee5682a69b2219b9919d ("tracepoint:
> Use struct pointer instead of name hash for reg/unreg tracepoints"),
> any tracepoints used in a kernel module must be exported.

NAK due to the lack of in-tree modules actually using it.