2014-04-25 02:52:55

by Jimmy Li

Subject: [PATCH]staging:iio:ad2s1200 fix missing parenthesis in a for statment.

Signed-off-by: Jimmy Li <[email protected]>
---
drivers/staging/iio/resolver/ad2s1200.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
index e2b4820..017d2f8 100644
--- a/drivers/staging/iio/resolver/ad2s1200.c
+++ b/drivers/staging/iio/resolver/ad2s1200.c
@@ -107,7 +107,7 @@ static int ad2s1200_probe(struct spi_device *spi)
int pn, ret = 0;
unsigned short *pins = spi->dev.platform_data;

- for (pn = 0; pn < AD2S1200_PN; pn++)
+ for (pn = 0; pn < AD2S1200_PN; pn++) {
ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT,
DRV_NAME);
if (ret) {
@@ -115,6 +115,7 @@ static int ad2s1200_probe(struct spi_device *spi)
pins[pn]);
return ret;
}
+ }
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
if (!indio_dev)
return -ENOMEM;
--
1.7.9.5

2014-04-26 10:03:20

by Jonathan Cameron

Subject: Re: [PATCH]staging:iio:ad2s1200 fix missing parenthesis in a for statment.

On 25/04/14 03:52, Jimmy Li wrote:
> Signed-off-by: Jimmy Li <[email protected]>

Applied to the fixes-togreg branch of iio.git

Thanks,
> ---
> drivers/staging/iio/resolver/ad2s1200.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
> index e2b4820..017d2f8 100644
> --- a/drivers/staging/iio/resolver/ad2s1200.c
> +++ b/drivers/staging/iio/resolver/ad2s1200.c
> @@ -107,7 +107,7 @@ static int ad2s1200_probe(struct spi_device *spi)
> int pn, ret = 0;
> unsigned short *pins = spi->dev.platform_data;
>
> - for (pn = 0; pn < AD2S1200_PN; pn++)
> + for (pn = 0; pn < AD2S1200_PN; pn++) {
> ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT,
> DRV_NAME);
> if (ret) {
> @@ -115,6 +115,7 @@ static int ad2s1200_probe(struct spi_device *spi)
> pins[pn]);
> return ret;
> }
> + }
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> if (!indio_dev)
> return -ENOMEM;
>