2014-04-28 11:27:15

by 敬锐

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

Hi Chris and Ulf,

This patch should be applied to 3.15(rc), 3.14, 3.13.
without this patch the MMC card can not identified.

Best Regards.
micky.
On 03/27/2014 01:35 PM, [email protected] wrote:
> From: Micky Ching <[email protected]>
>
> commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a
> <mmc: add ignorance case for CMD13 CRC error>
> produced a cmd.flags unhandled in realtek pci host driver.
> This will make MMC card failed initialize, this patch is
> used to handle the new cmd.flags condition and MMC card can be used.
>
> Signed-off-by: Micky Ching <[email protected]>
> ---
> drivers/mmc/host/rtsx_pci_sdmmc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index 5fb994f..0d8904a 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -346,6 +346,9 @@ static void sd_send_cmd(struct realtek_pci_sdmmc *host, struct mmc_command *cmd)
> case MMC_RSP_R1:
> rsp_type = SD_RSP_TYPE_R1;
> break;
> + case MMC_RSP_R1 & ~MMC_RSP_CRC:
> + rsp_type = SD_RSP_TYPE_R1 | SD_NO_CHECK_CRC7;
> + break;
> case MMC_RSP_R1B:
> rsp_type = SD_RSP_TYPE_R1b;
> break;


2014-04-28 12:16:56

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

On Mon, Apr 28, 2014 at 07:30:52PM +0800, micky wrote:
> Hi Chris and Ulf,
>
> This patch should be applied to 3.15(rc), 3.14, 3.13.
> without this patch the MMC card can not identified.
>

Top posting is annoying.

If Chris and Ulf don't mind then you could actually deal with this by
yourself. Read Documentation/stable_kernel_rules.txt

regards,
dan carpenter