On Fri, Mar 21, 2014 at 12:53:10PM +0800, Xiubo Li wrote:
> Now for the following scenarios:
>
> SoC | CPU | FTM-PWM | 'big-endian' property is needed?
> -------------|--------|---------|---------------------------------
> Vybird | LE | LE | No
> LS1 | LE | BE | Yes
> LS2 | LE | LE | No
>
> Signed-off-by: Xiubo Li <[email protected]>
> ---
> drivers/pwm/pwm-fsl-ftm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
And this should probably describe in text what happens. The table may
look good, but you don't give a real description of what the change
does.
Oh, and doesn't this change need to update the device tree binding since
you now have an additional property?
Thierry
> > Now for the following scenarios:
> >
> > SoC | CPU | FTM-PWM | 'big-endian' property is needed?
> > -------------|--------|---------|---------------------------------
> > Vybird | LE | LE | No
> > LS1 | LE | BE | Yes
> > LS2 | LE | LE | No
> >
> > Signed-off-by: Xiubo Li <[email protected]>
> > ---
> > drivers/pwm/pwm-fsl-ftm.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> And this should probably describe in text what happens. The table may
> look good, but you don't give a real description of what the change
> does.
>
I will follow your advice.
> Oh, and doesn't this change need to update the device tree binding since
> you now have an additional property?
>
Yes, you are right. I just forgot it.
I will add update it.
Thanks very much.
BRs
XIubo