2014-06-03 06:28:18

by Daeseok Youn

Subject: [PATCH 2/4] staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()

Pass "brd" to dgap_after_config_loaded() instead of passing
"dgap_numboards" and looking up brd again.

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/staging/dgap/dgap.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9501a5e..7a07a9b 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -187,7 +187,7 @@ static void dgap_do_fep_load(struct board_t *brd, const u8 *ufep, int len);
#ifdef DIGI_CONCENTRATORS_SUPPORTED
static void dgap_do_conc_load(struct board_t *brd, u8 *uaddr, int len);
#endif
-static int dgap_after_config_loaded(int board);
+static int dgap_after_config_loaded(struct board_t *brd);
static int dgap_finalize_board_init(struct board_t *brd);

static void dgap_get_vpd(struct board_t *brd);
@@ -859,7 +859,7 @@ static int dgap_firmware_load(struct pci_dev *pdev, int card_type)
kfree(dgap_config_buf);
}

- ret = dgap_after_config_loaded(brd->boardnum);
+ ret = dgap_after_config_loaded(brd);
if (ret)
return ret;
/*
@@ -4113,8 +4113,10 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
}
}

-static int dgap_after_config_loaded(int board)
+static int dgap_after_config_loaded(struct board_t *brd)
{
+ int board = brd->boardnum;
+
/*
* Initialize KME waitqueues...
*/
--
1.7.1

2014-06-03 07:22:16

by Dan Carpenter

Subject: Re: [PATCH 2/4] staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()

On Tue, Jun 03, 2014 at 03:27:28PM +0900, Daeseok Youn wrote:
> -static int dgap_after_config_loaded(int board)
> +static int dgap_after_config_loaded(struct board_t *brd)
> {
> + int board = brd->boardnum;
> +

We don't need to use "board" in this function. We can replaced
"dgap_board[board]->" with "brd->"

> /*
> * Initialize KME waitqueues...
> */

regards,
dan carpenter

2014-06-03 07:55:15

by Daeseok Youn

Subject: Re: [PATCH 2/4] staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()

2014-06-03 16:22 GMT+09:00 Dan Carpenter <[email protected]>:
> On Tue, Jun 03, 2014 at 03:27:28PM +0900, Daeseok Youn wrote:
>> -static int dgap_after_config_loaded(int board)
>> +static int dgap_after_config_loaded(struct board_t *brd)
>> {
>> + int board = brd->boardnum;
>> +
>
> We don't need to use "board" in this function. We can replaced
> "dgap_board[board]->" with "brd->"
OK. I will fix as your comment and resend.
Thanks

regards,
Daeseok Youn.
>
>> /*
>> * Initialize KME waitqueues...
>> */
>
> regards,
> dan carpenter
>