2014-06-01 09:33:23

by Johan Hovold

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

Remove the remaining two obsolete usb-serial subdriver entries from
MAINTAINERS, which were missed in the recent purge by commit
f896b7968b62 ("USB: Maintainers change for usb serial drivers").

Signed-off-by: Johan Hovold <[email protected]>
---
MAINTAINERS | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 51ebb779c5f3..68599b26f514 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9298,12 +9298,6 @@ S: Maintained
F: drivers/usb/host/isp116x*
F: include/linux/usb/isp116x.h

-USB KAWASAKI LSI DRIVER
-M: Oliver Neukum <[email protected]>
-L: [email protected]
-S: Maintained
-F: drivers/usb/serial/kl5kusb105.*
-
USB MASS STORAGE DRIVER
M: Matthew Dharm <[email protected]>
L: [email protected]
@@ -9331,12 +9325,6 @@ S: Maintained
F: Documentation/usb/ohci.txt
F: drivers/usb/host/ohci*

-USB OPTION-CARD DRIVER
-M: Matthias Urlichs <[email protected]>
-L: [email protected]
-S: Maintained
-F: drivers/usb/serial/option.c
-
USB PEGASUS DRIVER
M: Petko Manolov <[email protected]>
L: [email protected]
--
1.8.5.5


2014-06-01 17:46:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

On Sun, Jun 01, 2014 at 11:32:17AM +0200, Johan Hovold wrote:
> Remove the remaining two obsolete usb-serial subdriver entries from
> MAINTAINERS, which were missed in the recent purge by commit
> f896b7968b62 ("USB: Maintainers change for usb serial drivers").
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> MAINTAINERS | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 51ebb779c5f3..68599b26f514 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9298,12 +9298,6 @@ S: Maintained
> F: drivers/usb/host/isp116x*
> F: include/linux/usb/isp116x.h
>
> -USB KAWASAKI LSI DRIVER
> -M: Oliver Neukum <[email protected]>
> -L: [email protected]
> -S: Maintained
> -F: drivers/usb/serial/kl5kusb105.*
> -
> USB MASS STORAGE DRIVER
> M: Matthew Dharm <[email protected]>
> L: [email protected]
> @@ -9331,12 +9325,6 @@ S: Maintained
> F: Documentation/usb/ohci.txt
> F: drivers/usb/host/ohci*
>
> -USB OPTION-CARD DRIVER
> -M: Matthias Urlichs <[email protected]>
> -L: [email protected]
> -S: Maintained
> -F: drivers/usb/serial/option.c


Why are we taking away the maintainership of these individual drivers
from these developers? I had no problem giving you the drivers I was
supposed to be in charge of, but I need a signed-off-by from Matthias
and Oliver for these if they want to do the same.

thanks,

greg k-h

2014-06-02 07:16:39

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

On Sun, Jun 01, 2014 at 10:45:59AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Jun 01, 2014 at 11:32:17AM +0200, Johan Hovold wrote:
> > Remove the remaining two obsolete usb-serial subdriver entries from
> > MAINTAINERS, which were missed in the recent purge by commit
> > f896b7968b62 ("USB: Maintainers change for usb serial drivers").
> >
> > Signed-off-by: Johan Hovold <[email protected]>
> > ---
> > MAINTAINERS | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 51ebb779c5f3..68599b26f514 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9298,12 +9298,6 @@ S: Maintained
> > F: drivers/usb/host/isp116x*
> > F: include/linux/usb/isp116x.h
> >
> > -USB KAWASAKI LSI DRIVER
> > -M: Oliver Neukum <[email protected]>
> > -L: [email protected]
> > -S: Maintained
> > -F: drivers/usb/serial/kl5kusb105.*
> > -
> > USB MASS STORAGE DRIVER
> > M: Matthew Dharm <[email protected]>
> > L: [email protected]
> > @@ -9331,12 +9325,6 @@ S: Maintained
> > F: Documentation/usb/ohci.txt
> > F: drivers/usb/host/ohci*
> >
> > -USB OPTION-CARD DRIVER
> > -M: Matthias Urlichs <[email protected]>
> > -L: [email protected]
> > -S: Maintained
> > -F: drivers/usb/serial/option.c
>
> Why are we taking away the maintainership of these individual drivers
> from these developers? I had no problem giving you the drivers I was
> supposed to be in charge of, but I need a signed-off-by from Matthias
> and Oliver for these if they want to do the same.

I honestly thought you had just missed these entries when you removed
individual maintainership for the other usb-serial drivers with the
motivation that the developers were not around and that maintainership
for individual drivers did not make much sense anymore (as consolidation
proceeds, I read). (These two entries were also not grouped with the
others.)

Oliver and perhaps also Mathias are still around, but the option driver
is now down to about 200 LOC (including boilerplate) when not counting
the id table, while the kl5kusb105 is currently at about 400 LOC
(including boilerplate) since I converted it to use the generic
implementation a few years ago.

Oliver and Mathias, what do you think of this? Would you be willing to
sign off on this patch?

Thanks,
Johan

2014-06-02 07:43:43

by Matthias Urlichs

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

Hi,

Johan Hovold:
> > > -USB OPTION-CARD DRIVER
> > > -M: Matthias Urlichs <[email protected]>
> > > -L: [email protected]
> > > -S: Maintained
> > > -F: drivers/usb/serial/option.c
> >
> > Why are we taking away the maintainership of these individual drivers
> > from these developers? I had no problem giving you the drivers I was
> > supposed to be in charge of, but I need a signed-off-by from Matthias
> > and Oliver for these if they want to do the same.
>
> I honestly thought you had just missed these entries when you removed
> individual maintainership for the other usb-serial drivers with the
> motivation that the developers were not around and that maintainership
> for individual drivers did not make much sense anymore (as consolidation
> proceeds, I read). (These two entries were also not grouped with the
> others.)
>
> Oliver and perhaps also Mathias are still around, but the option driver
> is now down to about 200 LOC (including boilerplate) when not counting
> the id table, while the kl5kusb105 is currently at about 400 LOC
> (including boilerplate) since I converted it to use the generic
> implementation a few years ago.
>
> Oliver and Mathias, what do you think of this? Would you be willing to
> sign off on this patch?
>
Fine by me. While I am indeed "still around", Option doesn't need a
maintainer any more -- the thing just works, and I do not see any need
for driver-specific changes other than additions to the ID table.

You hardly need a maintainer for that.

--
-- Matthias Urlichs


Attachments:
(No filename) (1.51 kB)
signature.asc (819.00 B)
Digital signature
Download all attachments

2014-06-03 09:44:25

by Oliver Neukum

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

On Mon, 2014-06-02 at 09:16 +0200, Johan Hovold wrote:
> Oliver and perhaps also Mathias are still around, but the option
> driver
> is now down to about 200 LOC (including boilerplate) when not counting
> the id table, while the kl5kusb105 is currently at about 400 LOC
> (including boilerplate) since I converted it to use the generic
> implementation a few years ago.
>
> Oliver and Mathias, what do you think of this? Would you be willing to
> sign off on this patch?

Signed-off-by: Oliver Neukum <[email protected]>

Regards
Oliver

2014-06-03 12:02:51

by Matthias Urlichs

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

Hi,

Matthias Urlichs:
> Fine by me.

or, in other words:

Signed-Off-By: Matthias Urlichs <[email protected]>

--
-- Matthias Urlichs


Attachments:
(No filename) (138.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments

2014-06-23 10:41:41

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

On Tue, Jun 03, 2014 at 02:01:57PM +0200, Matthias Urlichs wrote:
> Hi,
>
> Matthias Urlichs:
> > Fine by me.
>
> or, in other words:
>
> Signed-Off-By: Matthias Urlichs <[email protected]>

I've now applied this to my usb-linus branch with yours and Oliver's
signed-offs.

Thanks,
Johan