2014-06-05 18:28:11

by Konrad Zapalowicz

Subject: [PATCH] net: phy: fix sparse warning in fixed.c

This commit fixes the following sparse warning:

drivers/net/phy/fixed.c:207
- warning: symbol 'fixed_phy_del' was not declared.
Should it be static?

by adding symbol definition to the phy_fixed.h API file. It is ok to do
because the function in question is an exported symbol.

Signed-off-by: Konrad Zapalowicz <[email protected]>
---
include/linux/phy_fixed.h | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
index 4f2478b..ae612ac 100644
--- a/include/linux/phy_fixed.h
+++ b/include/linux/phy_fixed.h
@@ -17,6 +17,7 @@ extern int fixed_phy_add(unsigned int irq, int phy_id,
extern int fixed_phy_register(unsigned int irq,
struct fixed_phy_status *status,
struct device_node *np);
+extern void fixed_phy_del(int phy_addr);
#else
static inline int fixed_phy_add(unsigned int irq, int phy_id,
struct fixed_phy_status *status)
@@ -29,6 +30,10 @@ static inline int fixed_phy_register(unsigned int irq,
{
return -ENODEV;
}
+static inline int fixed_phy_del(int phy_addr)
+{
+ return -ENODEV;
+}
#endif /* CONFIG_FIXED_PHY */

/*
--
1.8.1.2

2014-06-05 22:39:14

by David Miller

Subject: Re: [PATCH] net: phy: fix sparse warning in fixed.c

From: Konrad Zapalowicz <[email protected]>
Date: Thu, 5 Jun 2014 20:27:42 +0200

> This commit fixes the following sparse warning:
>
> drivers/net/phy/fixed.c:207
> - warning: symbol 'fixed_phy_del' was not declared.
> Should it be static?
>
> by adding symbol definition to the phy_fixed.h API file. It is ok to do
> because the function in question is an exported symbol.
>
> Signed-off-by: Konrad Zapalowicz <[email protected]>

Applied to net-next, thanks.