2014-06-05 18:38:06

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 1/1] kernel/locking/lockdep_proc.c: replace seq_printf and seq_puts

replace seq_printf by seq_puts and seq_puts by seq_putc where possible

Cc: Peter Zijlstra <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
kernel/locking/lockdep_proc.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
index ef43ac4..00c62ed 100644
--- a/kernel/locking/lockdep_proc.c
+++ b/kernel/locking/lockdep_proc.c
@@ -61,7 +61,7 @@ static int l_show(struct seq_file *m, void *v)
char usage[LOCK_USAGE_CHARS];

if (v == &all_lock_classes) {
- seq_printf(m, "all lock classes:\n");
+ seq_puts(m, "all lock classes:\n");
return 0;
}

@@ -77,18 +77,18 @@ static int l_show(struct seq_file *m, void *v)
get_usage_chars(class, usage);
seq_printf(m, " %s", usage);

- seq_printf(m, ": ");
+ seq_puts(m, ": ");
print_name(m, class);
- seq_puts(m, "\n");
+ seq_putc(m, '\n');

list_for_each_entry(entry, &class->locks_after, entry) {
if (entry->distance == 1) {
seq_printf(m, " -> [%p] ", entry->class->key);
print_name(m, entry->class);
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
}
- seq_puts(m, "\n");
+ seq_putc(m, '\n');

return 0;
}
@@ -141,7 +141,7 @@ static int lc_show(struct seq_file *m, void *v)
int i;

if (v == SEQ_START_TOKEN) {
- seq_printf(m, "all lock chains:\n");
+ seq_puts(m, "all lock chains:\n");
return 0;
}

@@ -154,9 +154,9 @@ static int lc_show(struct seq_file *m, void *v)

seq_printf(m, "[%p] ", class->key);
print_name(m, class);
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
- seq_puts(m, "\n");
+ seq_putc(m, '\n');

return 0;
}
@@ -529,7 +529,7 @@ static void seq_header(struct seq_file *m)
seq_puts(m, "lock_stat version 0.4\n");

if (unlikely(!debug_locks))
- seq_printf(m, "*WARNING* lock debugging disabled!! - possibly due to a lockdep warning\n");
+ seq_puts(m, "*WARNING* lock debugging disabled!! - possibly due to a lockdep warning\n");

seq_line(m, '-', 0, 40 + 1 + 12 * (14 + 1));
seq_printf(m, "%40s %14s %14s %14s %14s %14s %14s %14s %14s %14s %14s "
@@ -548,7 +548,7 @@ static void seq_header(struct seq_file *m)
"holdtime-total",
"holdtime-avg");
seq_line(m, '-', 0, 40 + 1 + 12 * (14 + 1));
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
}

static void *ls_start(struct seq_file *m, loff_t *pos)
--
1.8.4.5


2014-06-06 08:22:42

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH 1/1] kernel/locking/lockdep_proc.c: replace seq_printf and seq_puts

On Thu, Jun 05, 2014 at 08:36:48PM +0200, Fabian Frederick wrote:
> replace seq_printf by seq_puts and seq_puts by seq_putc where possible

Why?


Attachments:
(No filename) (145.00 B)
(No filename) (836.00 B)
Download all attachments