2014-06-12 04:02:21

by Andy Gross

[permalink] [raw]
Subject: Re: [PATCH 1/4] spi: qup: Remove chip select function

On Mon, May 19, 2014 at 11:07:38AM +0300, Ivan T. Ivanov wrote:
<snip>

> > +- num-cs: total number of chipselects
>
> My understanding is that "num-cs" have to be parsed by
> master driver, not by core SPI driver.

Right. I need to parse it and check vs the max cs and use that value to set the
master->num_chipselect

>
> > -
> > - /* Disable auto CS toggle and use manual */
> > - iocontol &= ~SPI_IO_C_MX_CS_MODE;
>
> Probably we should keep this?

Actually this is cleared in the probe during the initial settings of IO_CONTROL.
So this isn't necessary.


--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation