2014-06-12 10:34:41

by Pramod Gurav

Subject: [PATCH] staging: alarm-dev: Support to Compile as Module

From: Pramod Gurav <[email protected]>

Currently this alarm-dev can be compiles only as built in
driver. This adds support to compile it as module as well.
This has dependancy on:
https://lkml.org/lkml/2014/6/12/180

which exports symbol of alarmtimer function.

CC: Greg Kroah-Hartman <[email protected]>
CC: Brian Swetland <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
---
drivers/staging/android/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 99e484f..c359317 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
Registers processes to be killed when memory is low

config ANDROID_INTF_ALARM_DEV
- bool "Android alarm driver"
+ tristate "Android alarm driver"
depends on RTC_CLASS
default n
---help---
--
1.7.9.5

2014-06-12 16:51:43

by Greg KH

Subject: Re: [PATCH] staging: alarm-dev: Support to Compile as Module

On Thu, Jun 12, 2014 at 04:08:15PM +0530, [email protected] wrote:
> From: Pramod Gurav <[email protected]>
>
> Currently this alarm-dev can be compiles only as built in
> driver. This adds support to compile it as module as well.
> This has dependancy on:
> https://lkml.org/lkml/2014/6/12/180
>
> which exports symbol of alarmtimer function.
>
> CC: Greg Kroah-Hartman <[email protected]>
> CC: Brian Swetland <[email protected]>
> Signed-off-by: Pramod Gurav <[email protected]>
> ---
> drivers/staging/android/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 99e484f..c359317 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
> Registers processes to be killed when memory is low
>
> config ANDROID_INTF_ALARM_DEV
> - bool "Android alarm driver"
> + tristate "Android alarm driver"
> depends on RTC_CLASS
> default n
> ---help---

Please resend the first patch (it's not a "trivial one") as part of this
patch series.

And do you ever really want this code as a module? What will auto-load
it if needed?

thanks,

greg k-h

2014-06-12 16:58:10

by Pramod Gurav

Subject: Re: [PATCH] staging: alarm-dev: Support to Compile as Module

On Thu, Jun 12, 2014 at 10:25 PM, Greg Kroah-Hartman <[email protected]> wrote:
> On Thu, Jun 12, 2014 at 04:08:15PM +0530, [email protected] wrote:
>> From: Pramod Gurav <[email protected]>
>>
>> Currently this alarm-dev can be compiles only as built in
>> driver. This adds support to compile it as module as well.
>> This has dependancy on:
>> https://lkml.org/lkml/2014/6/12/180
>>
>> which exports symbol of alarmtimer function.
>>
>> CC: Greg Kroah-Hartman <[email protected]>
>> CC: Brian Swetland <[email protected]>
>> Signed-off-by: Pramod Gurav <[email protected]>
>> ---
>> drivers/staging/android/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
>> index 99e484f..c359317 100644
>> --- a/drivers/staging/android/Kconfig
>> +++ b/drivers/staging/android/Kconfig
>> @@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
>> Registers processes to be killed when memory is low
>>
>> config ANDROID_INTF_ALARM_DEV
>> - bool "Android alarm driver"
>> + tristate "Android alarm driver"
>> depends on RTC_CLASS
>> default n
>> ---help---
>
> Please resend the first patch (it's not a "trivial one") as part of this
> patch series.
>
Sure, Greg. will resend it.
> And do you ever really want this code as a module? What will auto-load
> it if needed?
>

The TODO of staging/android/ says 'make sure they all build well as
modules'. So thought of build testing it. It failed and tried to fix
it.
> thanks,
>
> greg k-h



--
Thanks and Regards
Pramod