2014-06-15 06:35:39

by Fabian Frédérick

Subject: [PATCH 1/1 RESEND] fs/ceph/export.c: add static to local function

ceph_get_parent is only used in fs/ceph/export.c

Cc: Sage Weil <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
fs/ceph/export.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/export.c b/fs/ceph/export.c
index 00d6af6..8d7d782 100644
--- a/fs/ceph/export.c
+++ b/fs/ceph/export.c
@@ -169,7 +169,7 @@ static struct dentry *__get_parent(struct super_block *sb,
return dentry;
}

-struct dentry *ceph_get_parent(struct dentry *child)
+static struct dentry *ceph_get_parent(struct dentry *child)
{
/* don't re-export snaps */
if (ceph_snap(child->d_inode) != CEPH_NOSNAP)
--
1.8.4.5

2014-06-17 00:02:21

by David Rientjes

Subject: Re: [PATCH 1/1 RESEND] fs/ceph/export.c: add static to local function

On Sun, 15 Jun 2014, Fabian Frederick wrote:

> ceph_get_parent is only used in fs/ceph/export.c
>
> Cc: Sage Weil <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/ceph/export.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/export.c b/fs/ceph/export.c
> index 00d6af6..8d7d782 100644
> --- a/fs/ceph/export.c
> +++ b/fs/ceph/export.c
> @@ -169,7 +169,7 @@ static struct dentry *__get_parent(struct super_block *sb,
> return dentry;
> }
>
> -struct dentry *ceph_get_parent(struct dentry *child)
> +static struct dentry *ceph_get_parent(struct dentry *child)
> {
> /* don't re-export snaps */
> if (ceph_snap(child->d_inode) != CEPH_NOSNAP)

Not sure what tree you're modifying, this is fixed by commit e84be11c5360
("ceph: ceph_get_parent() can be static") in Linus's tree.

2014-06-17 05:11:20

by Fabian Frédérick

Subject: Re: [PATCH 1/1 RESEND] fs/ceph/export.c: add static to local function

On Mon, 16 Jun 2014 17:02:17 -0700 (PDT)
David Rientjes <[email protected]> wrote:

> On Sun, 15 Jun 2014, Fabian Frederick wrote:
>
> > ceph_get_parent is only used in fs/ceph/export.c
> >
> > Cc: Sage Weil <[email protected]>
> > Cc: Andrew Morton <[email protected]>
> > Signed-off-by: Fabian Frederick <[email protected]>
> > ---
> > fs/ceph/export.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ceph/export.c b/fs/ceph/export.c
> > index 00d6af6..8d7d782 100644
> > --- a/fs/ceph/export.c
> > +++ b/fs/ceph/export.c
> > @@ -169,7 +169,7 @@ static struct dentry *__get_parent(struct super_block *sb,
> > return dentry;
> > }
> >
> > -struct dentry *ceph_get_parent(struct dentry *child)
> > +static struct dentry *ceph_get_parent(struct dentry *child)
> > {
> > /* don't re-export snaps */
> > if (ceph_snap(child->d_inode) != CEPH_NOSNAP)
>
> Not sure what tree you're modifying, this is fixed by commit e84be11c5360
> ("ceph: ceph_get_parent() can be static") in Linus's tree.
Strange, I sent first version some weeks ago and it wasn't there two days ago.
Maybe I missed a pull :)

Thanks,
Fabian