2014-06-04 12:37:14

by Daniel Thompson

Subject: [PATCH] irqchip: nvic: Use the generic noop function

Using the generic function saves looking up this custom one in a source
navigator.

Signed-off-by: Daniel Thompson <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Jason Cooper <[email protected]>
---
drivers/irqchip/irq-nvic.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 70bdf6e..c935c61 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
handle_IRQ(irq, regs);
}

-static void nvic_eoi(struct irq_data *d)
-{
- /*
- * This is a no-op as end of interrupt is signaled by the exception
- * return sequence.
- */
-}
-
static int __init nvic_of_init(struct device_node *node,
struct device_node *parent)
{
@@ -102,7 +94,7 @@ static int __init nvic_of_init(struct device_node *node,
gc->chip_types[0].regs.disable = NVIC_ICER;
gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
- gc->chip_types[0].chip.irq_eoi = nvic_eoi;
+ gc->chip_types[0].chip.irq_eoi = irq_gc_noop;

/* disable interrupts */
writel_relaxed(~0, gc->reg_base + NVIC_ICER);
--
1.9.0

2014-06-04 13:00:48

by Uwe Kleine-König

Subject: Re: [PATCH] irqchip: nvic: Use the generic noop function

On Wed, Jun 04, 2014 at 01:37:05PM +0100, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <[email protected]>
Acked-by: Uwe Kleine-K?nig <[email protected]>

thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |

2014-06-04 13:42:12

by Thomas Gleixner

Subject: Re: [PATCH] irqchip: nvic: Use the generic noop function

On Wed, 4 Jun 2014, Daniel Thompson wrote:

> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Jason Cooper <[email protected]>
> ---
> drivers/irqchip/irq-nvic.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
> index 70bdf6e..c935c61 100644
> --- a/drivers/irqchip/irq-nvic.c
> +++ b/drivers/irqchip/irq-nvic.c
> @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
> handle_IRQ(irq, regs);
> }
>
> -static void nvic_eoi(struct irq_data *d)
> -{
> - /*
> - * This is a no-op as end of interrupt is signaled by the exception
> - * return sequence.
> - */

You shred that information. Please move the comment above the
irq_gc_noop assignment.

Thanks,

tglx

2014-06-04 15:02:11

by Daniel Thompson

Subject: [PATCH v2] irqchip: nvic: Use the generic noop function

Using the generic function saves looking up this custom one in a source
navigator.

Signed-off-by: Daniel Thompson <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Jason Cooper <[email protected]>
---
drivers/irqchip/irq-nvic.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 70bdf6e..4ff0805 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
handle_IRQ(irq, regs);
}

-static void nvic_eoi(struct irq_data *d)
-{
- /*
- * This is a no-op as end of interrupt is signaled by the exception
- * return sequence.
- */
-}
-
static int __init nvic_of_init(struct device_node *node,
struct device_node *parent)
{
@@ -102,7 +94,10 @@ static int __init nvic_of_init(struct device_node *node,
gc->chip_types[0].regs.disable = NVIC_ICER;
gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
- gc->chip_types[0].chip.irq_eoi = nvic_eoi;
+ /* This is a no-op as end of interrupt is signaled by the
+ * exception return sequence.
+ */
+ gc->chip_types[0].chip.irq_eoi = irq_gc_noop;

/* disable interrupts */
writel_relaxed(~0, gc->reg_base + NVIC_ICER);
--
1.9.0

2014-06-21 02:14:21

by Jason Cooper

Subject: Re: [PATCH v2] irqchip: nvic: Use the generic noop function

On Wed, Jun 04, 2014 at 04:01:52PM +0100, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Jason Cooper <[email protected]>
> ---
> drivers/irqchip/irq-nvic.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)

Applied to irqchip/core with Uwe's Ack.

thx,

Jason.