2014-06-24 08:32:38

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 1/2] regulator: tps65217: Fix build warnings

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:

drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat <[email protected]>
---
Series compile tested.
---
drivers/regulator/tps65217-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c
index f7ed20a5a8b9..d58db72a63b0 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range tps65217_uv2_ranges[] = {
static int tps65217_pmic_enable(struct regulator_dev *dev)
{
struct tps65217 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);

if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
@@ -82,7 +82,7 @@ static int tps65217_pmic_enable(struct regulator_dev *dev)
static int tps65217_pmic_disable(struct regulator_dev *dev)
{
struct tps65217 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);

if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
--
1.7.9.5


2014-06-24 08:32:43

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 2/2] regulator: tps65218: Fix build warnings

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:
drivers/regulator/tps65218-regulator.c:132:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65218-regulator.c:146:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/regulator/tps65218-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index 69b4b7750410..8b24404be0bd 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -127,7 +127,7 @@ static int tps65218_pmic_set_voltage_sel(struct regulator_dev *dev,
static int tps65218_pmic_enable(struct regulator_dev *dev)
{
struct tps65218 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);

if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
return -EINVAL;
@@ -141,7 +141,7 @@ static int tps65218_pmic_enable(struct regulator_dev *dev)
static int tps65218_pmic_disable(struct regulator_dev *dev)
{
struct tps65218 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);

if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
return -EINVAL;
--
1.7.9.5

2014-06-24 15:23:37

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] regulator: tps65217: Fix build warnings

On Tue, Jun 24, 2014 at 01:59:15PM +0530, Sachin Kamat wrote:
> rdev_get_id() returns an int. Convert rid to type int to avoid the
> following warnings:

Applied, thanks.

Attachments:
(No filename) (171.00 B)
 signature.asc (819.00 B)
Digital signature Download all attachments

2014-06-24 15:25:38

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/2] regulator: tps65218: Fix build warnings

On Tue, Jun 24, 2014 at 01:59:16PM +0530, Sachin Kamat wrote:
> rdev_get_id() returns an int. Convert rid to type int to avoid the
> following warnings:
> drivers/regulator/tps65218-regulator.c:132:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> drivers/regulator/tps65218-regulator.c:146:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Applied, thanks.

Attachments:
(No filename) (427.00 B)
 signature.asc (819.00 B)
Digital signature Download all attachments