2014-06-26 06:56:39

by Grant Likely

[permalink] [raw]
Subject: Re: [PATCH] of: Transactional DT support.

On Wed, 25 Jun 2014 12:20:16 -0700, Dan Malek <[email protected]> wrote:
>
> On Jun 25, 2014, at 7:48 AM, Pantelis Antoniou <[email protected]> wrote:
>
> >>> +int of_transaction_commit(struct of_transaction *oft);
> >>
> >> How about of_transaction_apply()?
> >>
> >
> > Sure.
>
> LOL! Panto, you give in too easily :)
>
> Any transaction state diagrams I've seen always have a "commit" phase/state, never anything called "apply." So, of_transaction_commit() is exactly the proper name.

Hahaha. my suggestiong on name is conditional on my earlier comment to
make the API bulk-change instead of transaction oriented. Commit is
indeed the right name for a transactional model.

g.