2014-07-05 18:10:35

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH] machine_power_off: not only local_irq_disable but also do disable preemption

On Sat, Jul 05, 2014 at 10:44:41PM +0530, pawandeep oza wrote:
> process calls sys_reboot and that process then stops other CPUs while those
> CPUs are within a spin_lock() region we can potentially encounter a
> deadlock
> scenario like below.
>
> CPU 0 CPU 1
> ----- -----
> spin_lock(my_lock)
> smp_send_stop()
> <send IPI> handle_IPI()
> disable_preemption/irqs
> while(1);
> <PREEMPT>
> spin_lock(my_lock) <--- Waits forever

Please explain how that <PREEMPT> occurs with IRQs already disabled.

--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.